Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw when accessing IDL members on arbitrary objects with platform prototypes #11600

Closed
nox opened this issue Jun 4, 2016 · 2 comments
Closed

Throw when accessing IDL members on arbitrary objects with platform prototypes #11600

nox opened this issue Jun 4, 2016 · 2 comments
Labels
A-content/bindings The DOM bindings A-content/dom Interacting with the DOM from web content I-wrong An incorrect behaviour is observed.

Comments

@nox
Copy link
Contributor

nox commented Jun 4, 2016

See the test tests/wpt/web-platform-tests/dom/collections/HTMLCollection-as-proto-length-get-throws.html.

We probably don't implement the various "if O is not a platform object that implements interface I, throw a TypeError" steps that the WebIDL spec defines.
@nox nox added A-content/dom Interacting with the DOM from web content A-content/bindings The DOM bindings I-wrong An incorrect behaviour is observed. labels Jun 4, 2016
@nox
Copy link
Contributor Author

nox commented Jun 4, 2016

Blocks #2185.

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 6, 2016

This was fixed for Gecko in https://bugzilla.mozilla.org/show_bug.cgi?id=785941; the bug in Servo is probably similar.

nox added a commit to nox/servo that referenced this issue Aug 24, 2016
@nox
Pass the receiver to get_property_on_prototype (fixes servo#11600)
11f29bb
bors-servo pushed a commit that referenced this issue Aug 24, 2016
Auto merge of #13017 - nox:wrong-receiver, r=<try>
1148908 
Pass the receiver to get_property_on_prototype (fixes #11600)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13017)
<!-- Reviewable:end -->
nox added a commit to nox/servo that referenced this issue Aug 24, 2016
@nox
Pass the receiver to get_property_on_prototype (fixes servo#11600)
e8244eb
bors-servo pushed a commit that referenced this issue Aug 24, 2016
Auto merge of #13017 - nox:wrong-receiver, r=<try>
662f3d8 
Pass the receiver to get_property_on_prototype (fixes #11600)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13017)
<!-- Reviewable:end -->
nox added a commit to nox/servo that referenced this issue Aug 24, 2016
@nox
Pass the receiver to get_property_on_prototype (fixes servo#11600)
339bcb6
bors-servo pushed a commit that referenced this issue Aug 24, 2016
Auto merge of #13017 - nox:wrong-receiver, r=<try>
f5fdffa 
Pass the receiver to get_property_on_prototype (fixes #11600)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13017)
<!-- Reviewable:end -->
@jdm jdm mentioned this issue Aug 24, 2016
Merged
bors-servo pushed a commit that referenced this issue Aug 25, 2016
Auto merge of #13017 - nox:wrong-receiver, r=Ms2ger
6989d64 
Pass the receiver to get_property_on_prototype (fixes #11600)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13017)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Aug 25, 2016
Auto merge of #13017 - nox:wrong-receiver, r=Ms2ger
160d156 
Pass the receiver to get_property_on_prototype (fixes #11600)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13017)
<!-- Reviewable:end -->
samuknet pushed a commit to samuknet/servo that referenced this issue Sep 6, 2016
@nox @samuknet
Pass the receiver to get_property_on_prototype (fixes servo#11600)
16b75f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings The DOM bindings A-content/dom Interacting with the DOM from web content I-wrong An incorrect behaviour is observed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ms2ger @nox