Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step annotations for files related to WebBluetooth #12614

Closed
KiChjang opened this issue Jul 27, 2016 · 5 comments · Fixed by #13184
Closed

Step annotations for files related to WebBluetooth #12614

KiChjang opened this issue Jul 27, 2016 · 5 comments · Fixed by #13184
Labels
A-content/dom Interacting with the DOM from web content I-papercut Small but painful.

Comments

@KiChjang
Copy link
Contributor

cc @zakorgy
@KiChjang KiChjang added A-content/dom Interacting with the DOM from web content I-papercut Small but painful. labels Jul 27, 2016
@KiChjang KiChjang mentioned this issue Jul 27, 2016
Merged
3 tasks
@zakorgy
Copy link
Contributor

zakorgy commented Aug 1, 2016 •
edited

Cant this issue also contain the following WebBluetooth related files? bluetooth.rs, bluetoothremotegattdescriptor.rs, bluetoothremotegattserver.rs bluetoothremotegattservice.rs, components/net/bluetooth_thread.rs.
These files includes the following list of functions, which has no annotations yet.

  • requestDevice
  • getDescriptor
  • getDescriptors
  • readValue (characteristic)
  • writeValue (characteristic)
  • readValue (descriptor)
  • writeValue (descriptor)
  • connect
  • disconnect
  • getPrimaryService
  • getPrimaryServices
  • getCharacteristic
  • getCharacteristics
  • getIncludedService
  • getIncludedServices
  • startNotification
  • stopNotification
  • getAvailability
  • watchAdvertisements

@KiChjang KiChjang changed the title Step annotations for components/script/dom/bluetoothremotegattcharacteristic.rs Step annotations for files related to WebBluetooth Aug 1, 2016
@KiChjang
Copy link
Contributor Author

KiChjang commented Aug 1, 2016

Yes, title is changed accordingly.

This was referenced Aug 15, 2016
Closed
Merged
This was referenced Sep 5, 2016
Merged
Merged
bors-servo pushed a commit that referenced this issue Sep 15, 2016
Auto merge of #13184 - szeged:requestdevice-refactor, r=jdm
d92d699 
Webbluetooth requestDevice refactor and update

<!-- Please describe your changes on the following line: -->
Refactor requestDevice function according to the specification changes.
1. Moved the `request_bluetooth_devices` algorithm out from the `requestDevice` function.
2. Two new members in `BluetoothRequestDeviceFilter` and one new member in `RequestDeviceOptions`.
3. Also added annotations to the related functions.
Related links:
https://webbluetoothcg.github.io/web-bluetooth/#device-discovery,
https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetooth-requestdevice, https://webbluetoothcg.github.io/web-bluetooth/#request-bluetooth-devices,
https://webbluetoothcg.github.io/web-bluetooth/#matches-a-filter

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12614

<!-- Either: -->
- [x] These changes do not require tests because , there is no WebBluetooth Test API implementation yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13184)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Sep 15, 2016
Auto merge of #13184 - szeged:requestdevice-refactor, r=jdm
8334020 
Webbluetooth requestDevice refactor and update

<!-- Please describe your changes on the following line: -->
Refactor requestDevice function according to the specification changes.
1. Moved the `request_bluetooth_devices` algorithm out from the `requestDevice` function.
2. Two new members in `BluetoothRequestDeviceFilter` and one new member in `RequestDeviceOptions`.
3. Also added annotations to the related functions.
Related links:
https://webbluetoothcg.github.io/web-bluetooth/#device-discovery,
https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetooth-requestdevice, https://webbluetoothcg.github.io/web-bluetooth/#request-bluetooth-devices,
https://webbluetoothcg.github.io/web-bluetooth/#matches-a-filter

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12614

<!-- Either: -->
- [x] These changes do not require tests because , there is no WebBluetooth Test API implementation yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13184)
<!-- Reviewable:end -->
@zakorgy
Copy link
Contributor

zakorgy commented Sep 16, 2016

@KiChjang would you please reopen this issue? #13184 only fixes the requestDevice part.

@KiChjang KiChjang reopened this Sep 16, 2016
@dati91
Copy link
Contributor

dati91 commented Nov 22, 2016

#14324

This was referenced Nov 29, 2016
Merged
Merged
bors-servo pushed a commit that referenced this issue Nov 30, 2016
Auto merge of #14407 - szeged:annotations, r=jdm
1820bb5 
Annotations for WebBluetooth functions

<!-- Please describe your changes on the following line: -->
1. Moved the `convert_request_device_options` function steps into `request_bluetooth_devices` function, to stay consistent with the current specification.
2. Updated the existing step annotations for the requestDevice and related methods.
3. Added step annotations for the implemented WebBluetooth methods.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix  #14324, #12614

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14407)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Nov 30, 2016
Auto merge of #14407 - szeged:annotations, r=<try>
f2ca433 
Annotations for WebBluetooth functions

<!-- Please describe your changes on the following line: -->
1. Moved the `convert_request_device_options` function steps into `request_bluetooth_devices` function, to stay consistent with the current specification.
2. Updated the existing step annotations for the requestDevice and related methods.
3. Added step annotations for the implemented WebBluetooth methods.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix  #14324, #12614

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14407)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Nov 30, 2016
Auto merge of #14407 - szeged:annotations, r=jdm
9a902a7 
Annotations for WebBluetooth functions

<!-- Please describe your changes on the following line: -->
1. Moved the `convert_request_device_options` function steps into `request_bluetooth_devices` function, to stay consistent with the current specification.
2. Updated the existing step annotations for the requestDevice and related methods.
3. Added step annotations for the implemented WebBluetooth methods.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix  #14324, #12614

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14407)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Dec 1, 2016
Auto merge of #14407 - szeged:annotations, r=jdm
16199b4 
Annotations for WebBluetooth functions

<!-- Please describe your changes on the following line: -->
1. Moved the `convert_request_device_options` function steps into `request_bluetooth_devices` function, to stay consistent with the current specification.
2. Updated the existing step annotations for the requestDevice and related methods.
3. Added step annotations for the implemented WebBluetooth methods.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix  #14324, #12614

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14407)
<!-- Reviewable:end -->
@nox
Copy link
Contributor

nox commented Oct 4, 2017

The two unchecked methods have step annotations now.

@nox nox closed this as completed Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content I-papercut Small but painful.
Projects
None yet
Milestone
No milestone
4 participants
@nox @dati91 @KiChjang @zakorgy