Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borders of inline elements are wrong for broken lines #12699

Closed
splav opened this issue Aug 2, 2016 · 2 comments · Fixed by #12760
Closed

Borders of inline elements are wrong for broken lines #12699

splav opened this issue Aug 2, 2016 · 2 comments · Fixed by #12760
Labels
A-layout/inline C-assigned There is someone working on resolving the issue C-has-manual-testcase

Comments

@splav
Copy link
Contributor

splav commented Aug 2, 2016

Minimal test:

<!doctype html>
<html><body>
<style>
div {
  width: 5em;
}
span {
  border-left: yellow solid 0.5em;
  border-right: yellow solid 0.5em;
}
</style>
<div>
  <span>Very long text</span>
</div>
</body></html>

Servo:
screenshot_20160803_010231
Firefox:
firefox
@splav
Copy link
Contributor Author

splav commented Aug 2, 2016

As it interferes with my PR #12669 I would like to take this, at least in the part of extra borders, not sure about the positioning logic for now.

@jdm
Copy link
Member

jdm commented Aug 2, 2016

Go for it!

@jdm jdm added the C-assigned There is someone working on resolving the issue label Aug 2, 2016
@splav splav mentioned this issue Aug 7, 2016
Merged
5 tasks
bors-servo pushed a commit that referenced this issue Aug 8, 2016
Auto merge of #12760 - splav:inline_split_fixes#12699, r=<try>
15ffeba 
Inline split fixes#12699

<!-- Please describe your changes on the following line: -->
Fix fragment splitting algorithm to set FIRST/LAST_FRAGMENT_OF_ELEMENT flag correctly, account for border_padding for border_box and set zero border_padding between for new fragments.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12699 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12760)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Aug 8, 2016
Auto merge of #12760 - splav:inline_split_fixes#12699, r=notriddle
7ad120a 
Inline split fixes#12699

<!-- Please describe your changes on the following line: -->
Fix fragment splitting algorithm to set FIRST/LAST_FRAGMENT_OF_ELEMENT flag correctly, account for border_padding for border_box and set zero border_padding between for new fragments.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12699 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12760)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Aug 9, 2016
Auto merge of #12760 - splav:inline_split_fixes#12699, r=notriddle
2420dc4 
Inline split fixes#12699

<!-- Please describe your changes on the following line: -->
Fix fragment splitting algorithm to set FIRST/LAST_FRAGMENT_OF_ELEMENT flag correctly, account for border_padding for border_box and set zero border_padding between for new fragments.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12699 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12760)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/inline C-assigned There is someone working on resolving the issue C-has-manual-testcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inline split fixes#12699 splav/servo
2 participants
@jdm @splav