Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Navigator.cookieEnabled #13124

Closed
Manishearth opened this issue Aug 30, 2016 · 6 comments · Fixed by #13145
Closed

Implement Navigator.cookieEnabled #13124

Manishearth opened this issue Aug 30, 2016 · 6 comments · Fixed by #13145
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.

Comments

@Manishearth
Copy link
Member

Manishearth commented Aug 30, 2016

@Manishearth Manishearth added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. labels Aug 30, 2016
@highfive
Copy link

Please make a comment here if you intend to work on this issue. Thank you!

@ashrwin
Copy link
Contributor

ashrwin commented Aug 30, 2016

I'd like to work on this :)

@Manishearth Manishearth added the C-assigned There is someone working on resolving the issue label Aug 30, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 31, 2016

I think this should just return true.

@ashrwin
Copy link
Contributor

ashrwin commented Aug 31, 2016

Here-https://w3c.github.io/webappsec-suborigins/#cookies, cookie-averse does not necessarily mean cookies are disabled. So I too think that it should just return true.

@ashrwin
Copy link
Contributor

ashrwin commented Aug 31, 2016

@Manishearth What should be done in the tests?
For now I have added the interface in the interfaces.html and have also removed the corresponding expected FAIL lines from interfaces.html.ini.

@Manishearth
Copy link
Member Author

You shouldn't have to add the interface to interfaces.html (because it is NoInterfaceObject), just run it and remove the FAIL lines.

bors-servo pushed a commit that referenced this issue Sep 1, 2016
Implemented Navigator.cookieEnabled

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13124 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13145)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants