-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Navigator.cookieEnabled #13124
Comments
Please make a comment here if you intend to work on this issue. Thank you! |
I'd like to work on this :) |
I think this should just return true. |
Here-https://w3c.github.io/webappsec-suborigins/#cookies, cookie-averse does not necessarily mean cookies are disabled. So I too think that it should just return true. |
@Manishearth What should be done in the tests? |
You shouldn't have to add the interface to interfaces.html (because it is NoInterfaceObject), just run it and remove the FAIL lines. |
Implemented Navigator.cookieEnabled <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13124 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13145) <!-- Reviewable:end -->
You'll need to copy the NavigatorCookies implementation from https://html.spec.whatwg.org/multipage/webappapis.html#navigator and interface from https://html.spec.whatwg.org/multipage/webappapis.html#navigatorcookies
I think this should return the result of running
is_cookie_averse
on the associated document object, but I'm not 100% sure.The text was updated successfully, but these errors were encountered: