Fix unreachable_code warning. #14054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
@bors-servo r+ (After clicking "Synchronize" in the homu queue.) |
|
📌 Commit 53a481c has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo p=1 |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #14036) made this pull request unmergeable. Please resolve the merge conflicts. |
highfive
added
S-needs-rebase
SimonSapin
force-pushed
the
unreachable_code
branch
from
53a481c
to
28b0269
Compare
|
@bors-servo r+ |
|
📌 Commit 28b0269 has been approved by |
highfive
added
S-awaiting-merge
|
⌛ Testing commit 28b0269 with merge 7c6793f... |
bors-servo
pushed a commit
that referenced
this pull request
Nov 4, 2016
Fix unreachable_code warning. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14054) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt2 |
highfive
added
S-tests-failed
|
|
@bors-servo retry
|
|
⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, windows-dev are reusable. Rebuilding only mac-rel-wpt2... |
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is