Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite some http unit tests with fetch. #14163

Merged
merged 12 commits into from Nov 12, 2016
Merged

Rewrite some http unit tests with fetch. #14163

merged 12 commits into from Nov 12, 2016

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 10, 2016 •
edited by larsbergstrom

This change is Reviewable

@Ms2ger
Rewrite test_load_sets_cookies_in_the_resource_manager_when_it_get_se…
5bf90c5 
…t_cookie_header_in_response.
@Ms2ger
Rewrite test_load_sets_requests_cookies_header_for_url_by_getting_coo…
f1f090c 
…kies_from_the_resource_manager.
@Ms2ger
Rewrite test_load_sends_cookie_if_nonhttp.
52258e2
@Ms2ger
Rewrite test_cookie_set_with_httponly_should_not_be_available_using_g…
982c596 
…etcookiesforurl.
@Ms2ger
Rewrite test_when_cookie_received_marked_secure_is_ignored_for_http.
c229a01
@Ms2ger
Rewrite test_load_sets_content_length_to_length_of_request_body.
5a02586
@Ms2ger
Rewrite test_load_uses_explicit_accept_from_headers_in_load_data.
6319d7c
@Ms2ger
Rewrite test_load_sets_default_accept_to_html_xhtml_xml_and_then_anyt…
e12a6d7 
…hing_else.
@Ms2ger
Rewrite test_load_uses_explicit_accept_encoding_from_load_data_headers.
1957744
@Ms2ger
Rewrite test_load_sets_default_accept_encoding_to_gzip_and_deflate.
bced313
@Ms2ger
Rewrite test_load_errors_when_there_a_redirect_loop.
581c6df
@Ms2ger
Add a successful test for a redirect loop.
65602de
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 10, 2016
@metajack
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 65602de has been approved by metajack

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 11, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 65602de with merge b7660e2...

bors-servo pushed a commit that referenced this pull request Nov 11, 2016
Auto merge of #14163 - servo:fetch-unit-http, r=metajack
b7660e2 
Rewrite some http unit tests with fetch.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14163)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 12, 2016
@jdm
Copy link
Member

jdm commented Nov 12, 2016

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 65602de with merge a2689f2...

bors-servo pushed a commit that referenced this pull request Nov 12, 2016
Auto merge of #14163 - servo:fetch-unit-http, r=metajack
a2689f2 
Rewrite some http unit tests with fetch.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14163)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 12, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit 65602de into master Nov 12, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 12, 2016
@Ms2ger Ms2ger deleted the fetch-unit-http branch November 14, 2016 08:42
@Ms2ger Ms2ger mentioned this pull request Nov 18, 2016
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ms2ger @metajack @bors-servo @jdm @highfive