New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Document.open() and Document.close() #14591
Comments
I will give this a go. Would this be the place to go? https://github.com/servo/servo/blob/master/components/script/dom/document.rs |
Cancelling my go based on @KiChjang’s advice. |
This also hits us on Google Maps. |
Should we implement |
Pragmatically, I don't think it makes sense to try to solve the issues with |
Those sites that use the three argument version are already broken by it not existing, so I don't think the effect will be any worse. |
We can add the 3-argument overload and unconditionally throw on the Rust side; that's probably better than WebIDL's default of ignoring stray arguments. |
Seems like my job suddenly became easier to do: whatwg/html#1698 |
Blocks #13942.
Spec: https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-open, https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-close
The text was updated successfully, but these errors were encountered: