Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Document.open() and Document.close() #14591

Closed
jdm opened this issue Dec 14, 2016 · 8 comments
Closed

Implement Document.open() and Document.close() #14591

jdm opened this issue Dec 14, 2016 · 8 comments
Assignees
Labels

Comments

@dpyro
Copy link
Contributor

@dpyro dpyro commented Dec 18, 2016

I will give this a go. Would this be the place to go? https://github.com/servo/servo/blob/master/components/script/dom/document.rs

@dpyro
Copy link
Contributor

@dpyro dpyro commented Dec 18, 2016

Cancelling my go based on @KiChjang’s advice.

@jdm
Copy link
Member Author

@jdm jdm commented Dec 31, 2016

This also hits us on Google Maps.

@jdm jdm assigned nox Jan 4, 2017
@nox
Copy link
Member

@nox nox commented Jan 4, 2017

Should we implement window.open at the same time? I feel like implementing only the version of document.open that takes 2 arguments will break other sites trying to call the 3 arguments version.

@jdm
Copy link
Member Author

@jdm jdm commented Jan 4, 2017

Pragmatically, I don't think it makes sense to try to solve the issues with window.open at the same time.

@jdm
Copy link
Member Author

@jdm jdm commented Jan 4, 2017

Those sites that use the three argument version are already broken by it not existing, so I don't think the effect will be any worse.

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jan 4, 2017

We can add the 3-argument overload and unconditionally throw on the Rust side; that's probably better than WebIDL's default of ignoring stray arguments.

@nox
Copy link
Member

@nox nox commented Jan 24, 2017

Seems like my job suddenly became easier to do: whatwg/html#1698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.