Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Document.open() and Document.close() #14591
Comments
|
I will give this a go. Would this be the place to go? https://github.com/servo/servo/blob/master/components/script/dom/document.rs |
|
Cancelling my go based on @KiChjang’s advice. |
|
This also hits us on Google Maps. |
|
Should we implement |
|
Pragmatically, I don't think it makes sense to try to solve the issues with |
|
Those sites that use the three argument version are already broken by it not existing, so I don't think the effect will be any worse. |
|
We can add the 3-argument overload and unconditionally throw on the Rust side; that's probably better than WebIDL's default of ignoring stray arguments. |
|
Seems like my job suddenly became easier to do: whatwg/html#1698 |
Blocks #13942.
Spec: https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-open, https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-close