Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid unused imports #1480

Closed
jdm opened this issue Jan 13, 2014 · 2 comments · Fixed by #1939
Closed

Forbid unused imports #1480

jdm opened this issue Jan 13, 2014 · 2 comments · Fixed by #1939
Labels
A-infrastructure E-less-complex Straightforward. Recommended for a new contributor.

Comments

@jdm
Copy link
Member

jdm commented Jan 13, 2014

rustc -D unused-imports

Do we dare?
@metajack
Copy link
Contributor

+1

@zmike
Copy link
Contributor

zmike commented Jan 15, 2014

It builds fine with this at present, so there's nothing major preventing it...

@khodzha khodzha mentioned this issue Mar 19, 2014
Merged
bors-servo pushed a commit that referenced this issue Mar 19, 2014
auto merge of #1939 : khodzha/servo/unused_imports, r=jdm
238f28e 
Attempt to fix #1480. I have no idea what I'm doing
bors-servo pushed a commit that referenced this issue Mar 20, 2014
auto merge of #1939 : khodzha/servo/unused_imports, r=jdm
371bea7 
Attempt to fix #1480. I have no idea what I'm doing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-infrastructure E-less-complex Straightforward. Recommended for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added -D unused-imports to rustc flags
3 participants
@jdm @metajack @zmike