Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop generating flows under display:none #1536

Closed
pcwalton opened this issue Jan 23, 2014 · 0 comments
Closed

Stop generating flows under display:none #1536

pcwalton opened this issue Jan 23, 2014 · 0 comments
Assignees
@mbrubeck
Labels
A-layout/tree-builder B-interesting-project Represents work that is expected to be interesting in some fashion C-assigned There is someone working on resolving the issue I-perf-slow Unnecessary performance degredation.

Comments

@pcwalton
Copy link
Contributor

Because this is a bottom-up traversal we generate flows and throw them away. We should stop doing that. Instead we can use a magic non-exposed property that is cascaded, -servo-under-display-none: yes.
@mbrubeck mbrubeck added I-perf-slow Unnecessary performance degredation. B-interesting-project Represents work that is expected to be interesting in some fashion A-layout/tree-builder and removed A-layout/uncategorized labels May 25, 2016
mbrubeck added a commit to mbrubeck/servo that referenced this issue May 25, 2016
@mbrubeck
Stop generating flows under display: none.
6f818fd 
Because this is a bottom-up traversal it can generates flows and throw them away. To prevent that, this cascades an internal `-servo-under-display-none` property and then checks that during flow construction.  Fixes servo#1536.
@mbrubeck mbrubeck self-assigned this May 25, 2016
@mbrubeck mbrubeck added the C-assigned There is someone working on resolving the issue label May 25, 2016
mbrubeck added a commit to mbrubeck/servo that referenced this issue May 25, 2016
@mbrubeck
Stop generating flows under display: none.
5338fce 
Because this is a bottom-up traversal it can generates flows and throw them away. To prevent that, this cascades an internal `-servo-under-display-none` property and then checks that during flow construction.  Fixes servo#1536.
mbrubeck added a commit to mbrubeck/servo that referenced this issue May 25, 2016
@mbrubeck
Stop generating flows under display: none.
5c09e26 
Because this is a bottom-up traversal it can generates flows and throw them away. To prevent that, this cascades an internal `-servo-under-display-none` property and then checks that during flow construction.  Fixes servo#1536.
@mbrubeck mbrubeck mentioned this issue May 25, 2016
Merged
bors-servo pushed a commit that referenced this issue May 25, 2016
Auto merge of #11427 - mbrubeck:under-display-none, r=pcwalton
92ae502 
Stop generating flows under display: none.

Because this is a bottom-up traversal it can generates flows and throw them away. To prevent that, this cascades an internal `-servo-under-display-none` property and then checks that during flow construction.  Fixes #1536.

r? @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11427)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbrubeck mbrubeck

Labels
A-layout/tree-builder B-interesting-project Represents work that is expected to be interesting in some fashion C-assigned There is someone working on resolving the issue I-perf-slow Unnecessary performance degredation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbrubeck @jdm @pcwalton