Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rustc-serialize from range #15515

Merged
merged 2 commits into from
Feb 12, 2017
Merged

Remove rustc-serialize from range #15515

merged 2 commits into from
Feb 12, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Feb 12, 2017 •
edited by larsbergstrom
Loading

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/conversions.rs
  • @KiChjang: components/script/dom/bindings/conversions.rs

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 12, 2017
@jdm
Copy link
Member

jdm commented Feb 12, 2017

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 58046cc has been approved by jdm

@highfive highfive assigned jdm and unassigned Manishearth Feb 12, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 12, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 58046cc with merge 89dcbec...

bors-servo pushed a commit that referenced this pull request Feb 12, 2017
Auto merge of #15515 - nox:rustc-serialize, r=jdm
89dcbec 
Remove rustc-serialize from range

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15515)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 12, 2017
@jdm
Copy link
Member

jdm commented Feb 12, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only mac-rel-css...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: jdm
Pushing 89dcbec to master...

@bors-servo bors-servo merged commit 58046cc into servo:master Feb 12, 2017
@bors-servo bors-servo mentioned this pull request Feb 12, 2017
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nox @highfive @jdm @bors-servo @Manishearth