Remove ArrayBufferViewContents trait #15650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon. |
|
|
highfive
added
the
S-awaiting-review
|
@bors-servo r+ |
|
📌 Commit cb3f8c9 has been approved by |
highfive
added
S-awaiting-merge
|
I was actually just about to make a pull request for this |
bors-servo
pushed a commit
that referenced
this pull request
Feb 20, 2017
…nSapin Remove ArrayBufferViewContents trait <!-- Please describe your changes on the following line: --> Removed ArrayBufferViewContents trait and dependent uses. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ x ] `./mach build -d` does not report any errors - [ x ] `./mach test-tidy` does not report any errors - [ x ] These changes fix #15551 <!-- Either: --> - [ x ] These changes do not require tests because it's just unused trait and @jdm said, "No need for automated tests; if the build succeeds, it's good enough for a PR." <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15650) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
|
@Greeene In future, please do not work on issues that have already been assigned to someone without first asking whether that is appropriate. |
|
@jdm @hgallagher1993 I'm sorry for that. I'll be more attentive next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed ArrayBufferViewContents trait and dependent uses.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is