Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ArrayBufferViewContents trait #15650

Merged
merged 1 commit into from
Feb 20, 2017
Merged

Remove ArrayBufferViewContents trait #15650

merged 1 commit into from
Feb 20, 2017

Conversation

lunaryone
Copy link

@lunaryone lunaryone commented Feb 19, 2017

Removed ArrayBufferViewContents trait and dependent uses.


  • [ x ] These changes do not require tests because it's just unused trait and @jdm said, "No need for automated tests; if the build succeeds, it's good enough for a PR."

This change is Reviewable

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/conversions.rs
  • @KiChjang: components/script/dom/bindings/conversions.rs

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 19, 2017
@SimonSapin
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit cb3f8c9 has been approved by SimonSapin

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 19, 2017
@hgallagher1993
Copy link
Contributor

I was actually just about to make a pull request for this

@bors-servo
Copy link
Contributor

⌛ Testing commit cb3f8c9 with merge 82d05a0...

bors-servo pushed a commit that referenced this pull request Feb 20, 2017
…nSapin

Remove ArrayBufferViewContents trait

<!-- Please describe your changes on the following line: -->
Removed ArrayBufferViewContents trait and dependent uses.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ x ] `./mach build -d` does not report any errors
- [ x ] `./mach test-tidy` does not report any errors
- [ x ] These changes fix #15551

<!-- Either: -->
- [ x ] These changes do not require tests because it's just unused trait and @jdm said, "No need for automated tests; if the build succeeds, it's good enough for a PR."

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15650)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: SimonSapin
Pushing 82d05a0 to master...

@bors-servo bors-servo merged commit cb3f8c9 into servo:master Feb 20, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 20, 2017
@lunaryone lunaryone deleted the rm_array_buffer_contents_trait branch February 20, 2017 09:14
@jdm
Copy link
Member

jdm commented Feb 20, 2017

@Greeene In future, please do not work on issues that have already been assigned to someone without first asking whether that is appropriate.

@lunaryone
Copy link
Author

@jdm @hgallagher1993 I'm sorry for that. I'll be more attentive next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ArrayBufferViewContents trait
6 participants