Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement element.innerText #16107

Closed
ferjm opened this issue Mar 23, 2017 · 3 comments · Fixed by #20054
Closed

Implement element.innerText #16107

ferjm opened this issue Mar 23, 2017 · 3 comments · Fixed by #20054
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue

Comments

@ferjm
Copy link
Contributor

ferjm commented Mar 23, 2017

Spec: https://html.spec.whatwg.org/multipage/dom.html#the-innertext-idl-attribute

May block #13942
@ferjm ferjm added the A-content/dom Interacting with the DOM from web content label Mar 23, 2017
@Ms2ger Ms2ger mentioned this issue Mar 23, 2017
Open
13 tasks
@ferjm ferjm self-assigned this Mar 23, 2017
@ferjm ferjm added the C-assigned There is someone working on resolving the issue label Mar 23, 2017
@jasonwilliams
Copy link
Contributor

Hey @ferjm whats your plan of action for this?

@ferjm
Copy link
Contributor Author

ferjm commented Mar 31, 2017

Hello @Jayflux, I have a WIP patch for this that I'd like to finish next week (I'm afk today).

@ferjm ferjm mentioned this issue Apr 6, 2017
Closed
4 tasks
@ferjm ferjm removed their assignment Aug 16, 2017
@ferjm ferjm mentioned this issue Feb 15, 2018
Merged
4 tasks
@ferjm
Copy link
Contributor Author

ferjm commented Feb 15, 2018

The getter part landed in #19754

bors-servo pushed a commit that referenced this issue Feb 15, 2018
Auto merge of #20054 - ferjm:innertext.setter, r=<try>
8d14fb5 
Implement element.innerText setter

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #16107
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20054)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Feb 16, 2018
Auto merge of #20054 - ferjm:innertext.setter, r=emilio
a6113af 
Implement element.innerText setter

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #16107
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20054)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue
Projects
None yet
Milestone
No milestone
2 participants
@ferjm @jasonwilliams