Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paint worklets: cache previous results #17369

Closed
asajeffrey opened this issue Jun 16, 2017 · 2 comments
Closed

Paint worklets: cache previous results #17369

asajeffrey opened this issue Jun 16, 2017 · 2 comments
Assignees
@asajeffrey
Labels
A-content/css Interacting with CSS from web content (parsing, serializing, introspection) A-content/script Related to the script thread

Comments

@asajeffrey
Copy link
Member

At the moment, paint worklets are called every time the display list is built. We should change this to use a (one-place?) cache of previous results.
@asajeffrey asajeffrey added A-content/css Interacting with CSS from web content (parsing, serializing, introspection) A-content/script Related to the script thread labels Jun 16, 2017
@asajeffrey asajeffrey self-assigned this Jun 16, 2017
This was referenced Jul 18, 2017
Closed
Merged
bors-servo pushed a commit that referenced this issue Jul 31, 2017
Auto merge of #17810 - asajeffrey:script-paint-worklets-speculative-e…
cf5602e 
…valuation, r=emilio

Script paint worklets speculative evaluation

<!-- Please describe your changes on the following line: -->

This PR speculatively calls paint worklets during style, which increases the concurrency, since it increases the chance that the cache will have the right result in it when it comes to layout. The speculation is wasted effort if the size of the element has changed, but this is often not the case.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17486 and #17369.
- [X] These changes do not require tests because it's a performance improvement

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17810)
<!-- Reviewable:end -->
@atouchet
Copy link
Contributor

atouchet commented Aug 9, 2017

Was this fixed in #17810?

@asajeffrey
Copy link
Member Author

Good point, yes it was fixed in #17810.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
A-content/css Interacting with CSS from web content (parsing, serializing, introspection) A-content/script Related to the script thread
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Paint worklets: one-place cache of results asajeffrey/servo
2 participants
@asajeffrey @atouchet