Limit visited cascade for reparenting #18844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specialized cascade flow in `stylist::compute_style_with_inputs` (used with reparenting) currently computes all properties for visited styles, but we only need visited-dependent properties. This adds the cascade flag to reduce the work to visited-dependent properties only, like we do for the regular cascade flow. MozReview-Commit-ID: FGCj6GPnQOB
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
|
@bors-servo r=emilio |
|
📌 Commit 0eb7d65 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Oct 12, 2017
Limit visited cascade for reparenting The specialized cascade flow in `stylist::compute_style_with_inputs` (used with reparenting) currently computes all properties for visited styles, but we only need visited-dependent properties. This adds the cascade flag to reduce the work to visited-dependent properties only, like we do for the regular cascade flow. https://bugzilla.mozilla.org/show_bug.cgi?id=1407813 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18844) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specialized cascade flow in
stylist::compute_style_with_inputs(used withreparenting) currently computes all properties for visited styles, but we only
need visited-dependent properties.
This adds the cascade flag to reduce the work to visited-dependent properties
only, like we do for the regular cascade flow.
https://bugzilla.mozilla.org/show_bug.cgi?id=1407813
This change is