layout: Add support for clear on <br> elements
#32094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<br>` elements are a bit "special" in the sense that they defer a linebreak, but can also have `clear` applied to them. The `clear` that they supply should be applie *after* the linebreak is processed. This change adds special processing for this situation. Fixes servo#15402.
|
🔨 Triggering try run (#8705706012) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#8705706012): Flaky unexpected result (27)
Stable unexpected results that are known to be intermittent (8)
|
|
✨ Try run (#8705706012) succeeded. |
Loirooriol
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
These cases are not consistent:
<!DOCTYPE html>
<div style="float: left; width: 100px; height: 100px; background: cyan"></div>
<div style="height: 50px; width: 150px; background: magenta"></div>
<br style="clear: both; display: inline; margin-top: 100px">a
<hr>
<div style="float: left; width: 100px; height: 100px; background: cyan"></div>
<div style="height: 50px; width: 150px; background: magenta"></div>
<br style="clear: both; display: block; margin-top: 100px">a| Servo | Gecko | Blink |
|---|---|---|
 |
 |
 |
But Gecko and Blink, while self-consistent, are not interoperable, so I guess it's fine. Also setting display on a <br> is quite broken in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<br>elements are a bit "special" in the sense that they defer alinebreak, but can also have
clearapplied to them. Theclearthatthey supply should be applied after the linebreak is processed. This
change adds special processing for this situation.
Fixes #15402.
Fixes #8960.
Fixes #7311.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsclear:bothnot working when applied to<br>element #15402.