Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WebVTT format #22312

Open
Tracked by #22314
ferjm opened this issue Nov 29, 2018 · 4 comments
Open
Tracked by #22314

Support for WebVTT format #22312

ferjm opened this issue Nov 29, 2018 · 4 comments
Labels
A-content/media E-very-complex Very difficult. Do not attempt without significant relevant experience and motivation.

Comments

@ferjm
Copy link
Contributor

ferjm commented Nov 29, 2018

Spec: https://w3c.github.io/webvtt

@ferjm ferjm added E-very-complex Very difficult. Do not attempt without significant relevant experience and motivation. A-content/media labels Nov 29, 2018
@ferjm
Copy link
Contributor Author

ferjm commented Nov 29, 2018

@ferjm ferjm added this to Backlog in Media playback Nov 29, 2018
@iulianR
Copy link
Contributor

iulianR commented Mar 4, 2020

I talked with @jdm on Matrix and he said it's OK if I try to implement VTTRegion WebIDL interface. I managed to do that (some more tests pass, but I probably missed some things) and I pushed my changes here. Adding VTTCue seems straightforward as well and I would like to do that as well, and afterwards see what else I can do.

Before starting on VTTCue I thought I would mention here in case someone else might think about starting work on this.

@jdm
Copy link
Member

jdm commented Mar 9, 2020

Some brief investigation into how webkit + gstreamer integrates VTT:

bors-servo pushed a commit that referenced this issue Mar 9, 2020
Add VTTRegion and part of VTTCue DOM interfaces

<!-- Please describe your changes on the following line: -->
Hello! In this PR I implemented the VTTRegion DOM interface and part of VTTCue (#22312). Before continuing I thought it's maybe a good idea to first request a review or even merge what I did up to this point, as I might get stuck on the next part. I have a slight idea of what needs to be done (I assume it's hooking the GStreamer parser somewhere in `GetCueAsHTML()`), but a short outline or some more instructions would help a lot.

I updated test expectations by first running:
```
./mach test-wpt tests/wpt/web-platform-tests/webvtt/api --log-raw servo.log --pref dom.webvtt.enabled=true
```
then
```
./mach update-wpt servo.log
```
Thanks!
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@jdm
Copy link
Member

jdm commented Mar 9, 2020

To be clear, the gstreamer-related work will need to happen in https://github.com/servo/media:

Once the interface exists, it can be used to interact with the DOM side of Servo via this field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-content/media E-very-complex Very difficult. Do not attempt without significant relevant experience and motivation.
Projects
Media playback
  
Backlog
Development

No branches or pull requests

3 participants