Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace chain member in JSRef with contravariant marker #2333

Closed
jdm opened this issue May 5, 2014 · 2 comments · Fixed by #2435
Closed

Replace chain member in JSRef with contravariant marker #2333

jdm opened this issue May 5, 2014 · 2 comments · Fixed by #2435
Labels
A-content/bindings The DOM bindings E-less-complex Straightforward. Recommended for a new contributor.

Comments

@jdm
Copy link
Member

jdm commented May 5, 2014

<kmc> jdm: hmm, the &'a () in JSRef<'a, T> will take up a word, but I think it could be std::kinds::marker::ContravariantLifetime<'a> instead, which has size zero
@jdm
Copy link
Member Author

jdm commented May 5, 2014

@pcwalton Does this sound correct to you?

@pcwalton
Copy link
Contributor

@jdm Yes, that sounds correct.

@jdm jdm added the E-easy label May 13, 2014
@zwarich zwarich mentioned this issue May 14, 2014
Merged
@zwarich zwarich self-assigned this May 14, 2014
bors-servo pushed a commit that referenced this issue May 15, 2014
auto merge of #2435 : zwarich/servo/contravariant-lifetime, r=jdm
51d1284 
Since ContravariantLifetime doesn't take up any storage space, this
means that JSRef will be a single word. This fixes #2333.
@jdm jdm unassigned zwarich Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings The DOM bindings E-less-complex Straightforward. Recommended for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to using ContravariantLifetime in JSRef<'a, T>.
3 participants
@jdm @pcwalton @zwarich