Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support features in webxr, require feature for local-floor access #24270

Closed
Manishearth opened this issue Sep 23, 2019 · 3 comments
Closed

Support features in webxr, require feature for local-floor access #24270

Manishearth opened this issue Sep 23, 2019 · 3 comments
Labels
A-xr-spec-complete Things necessary to support the full WebXR spec A-xr-zomg AR/VR/MR

Comments

@Manishearth
Copy link
Member

Manishearth commented Sep 23, 2019 •
edited

https://immersive-web.github.io/webxr/#feature-dependencies

We need to support features, and gate the existence of local-floor on the local-floor feature (also the respective features when #24194, #24195 happen)

We should also make inline sessions not require activation if tracking isn't requested (#24133 (comment))
@Manishearth Manishearth added A-xr-zomg AR/VR/MR A-xr-spec-complete Things necessary to support the full WebXR spec labels Sep 23, 2019
@Manishearth Manishearth mentioned this issue Sep 24, 2019
Merged
@Manishearth Manishearth mentioned this issue Dec 6, 2019
Merged
3 tasks
@Manishearth
Copy link
Member Author

We'll also need to require the local feature for local spaces in inline sessions.

bors-servo pushed a commit that referenced this issue Dec 6, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
77364e8 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 6, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
07aeb87 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 11, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
5bc0f92 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 11, 2019
Auto merge of #25144 - Manishearth:inline, r=<try>
47293be 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 11, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
50cfa4d 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 11, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
4393cfe 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 11, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
16e1211 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 12, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
232237f 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 12, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
208faf6 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 12, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
073194a 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
@Manishearth Manishearth mentioned this issue Jan 13, 2020
Merged
2 tasks
bors-servo pushed a commit that referenced this issue Jan 21, 2020
Auto merge of #25504 - Manishearth:features, r=asajeffrey
963ded8 
Support features in webxr

Based on servo/webxr#119

Todo:
 - [x] gate reference space creation on feature presence
 - [x] Fix the `features_deviceSupport` test to correctly use simulateUserActivation

Fixes #24196, #24270
r? @jdm @asajeffrey
bors-servo pushed a commit that referenced this issue Jan 22, 2020
Auto merge of #25504 - Manishearth:features, r=asajeffrey
ee3fb92 
Support features in webxr

Based on servo/webxr#119

Todo:
 - [x] gate reference space creation on feature presence
 - [x] Fix the `features_deviceSupport` test to correctly use simulateUserActivation

Fixes #24196, #24270
r? @jdm @asajeffrey
@atouchet
Copy link
Contributor

Did #25504 fix this?

@Manishearth
Copy link
Member Author

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-xr-spec-complete Things necessary to support the full WebXR spec A-xr-zomg AR/VR/MR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Manishearth @atouchet