Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove assertion for negative value from get_uniform_location #26150
Labels
Comments
|
This is known to trigger in babylon.js content with |
bors-servo
added a commit
that referenced
this issue
Apr 10, 2020
Remove assertion for negative value from get_uniform_location closes #26150 - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26150 (GitHub issue number if applicable) - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___
bors-servo
added a commit
that referenced
this issue
Apr 10, 2020
Remove assertion for negative value from get_uniform_location closes #26150 - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26150 (GitHub issue number if applicable) - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___
bors-servo
added a commit
that referenced
this issue
Apr 10, 2020
Remove assertion for negative value from get_uniform_location closes #26150 - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26150 (GitHub issue number if applicable) - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___
bors-servo
added a commit
that referenced
this issue
Apr 10, 2020
Remove assertion for negative value from get_uniform_location closes #26150 - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26150 (GitHub issue number if applicable) - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
servo/components/canvas/webgl_thread.rs
Line 2300 in e1dd0d9
It's entirely possible for web content to pass values that will known result in a known uniform location. This means that a return value of -1 is reasonable and we shouldn't assert against it.