Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assertion for negative value from get_uniform_location #26150

Closed
jdm opened this issue Apr 8, 2020 · 1 comment · Fixed by #26163
Closed

Remove assertion for negative value from get_uniform_location #26150

jdm opened this issue Apr 8, 2020 · 1 comment · Fixed by #26163
Labels
A-content/webgl 3d canvas API I-panic Servo encounters a panic.

Comments

@jdm
Copy link
Member

jdm commented Apr 8, 2020

servo/components/canvas/webgl_thread.rs

Line 2300 in e1dd0d9

assert!(location >= 0);

It's entirely possible for web content to pass values that will known result in a known uniform location. This means that a return value of -1 is reasonable and we shouldn't assert against it.
@jdm jdm added I-panic Servo encounters a panic. A-content/webgl 3d canvas API labels Apr 8, 2020
@jdm
Copy link
Member Author

jdm commented Apr 8, 2020

This is known to trigger in babylon.js content with dom.webgl2.enabled set to true.

@dralley dralley mentioned this issue Apr 10, 2020
Merged
5 tasks
bors-servo added a commit that referenced this issue Apr 10, 2020
@bors-servo
Auto merge of #26163 - dralley:remove-assertion, r=<try>
d3f04af 
Remove assertion for negative value from get_uniform_location

closes #26150

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26150 (GitHub issue number if applicable)
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
bors-servo added a commit that referenced this issue Apr 10, 2020
@bors-servo
Auto merge of #26163 - dralley:remove-assertion, r=jdm
dccaa43 
Remove assertion for negative value from get_uniform_location

closes #26150

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26150 (GitHub issue number if applicable)
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
bors-servo added a commit that referenced this issue Apr 10, 2020
@bors-servo
Auto merge of #26163 - dralley:remove-assertion, r=jdm
5e30d2f 
Remove assertion for negative value from get_uniform_location

closes #26150

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26150 (GitHub issue number if applicable)
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
bors-servo added a commit that referenced this issue Apr 10, 2020
@bors-servo
Auto merge of #26163 - dralley:remove-assertion, r=jdm
e43cadb 
Remove assertion for negative value from get_uniform_location

closes #26150

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26150 (GitHub issue number if applicable)
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
nosark pushed a commit to nosark/servo that referenced this issue Jul 19, 2020
@dralley @nosark
Remove assertion for negative value from get_uniform_location
3ee9fef 
closes servo#26150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/webgl 3d canvas API I-panic Servo encounters a panic.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove assertion for negative value from get_uniform_location dralley/servo
1 participant
@jdm