Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IOCompositor's current_pos field #32632

Closed
wusyong opened this issue Jun 27, 2024 · 0 comments · Fixed by #32718
Closed

Remove IOCompositor's current_pos field #32632

wusyong opened this issue Jun 27, 2024 · 0 comments · Fixed by #32718
Labels
A-embedding B-feature-tracking This issue tracks a particular high-level feature

Comments

@wusyong
Copy link
Member

wusyong commented Jun 27, 2024

Describe the new feature:
I was tracing a bug that caused the cursor to constantly reset to the default when in animation. And I found current_pos isn't set after initialized, and it will always be (0, 0) pass to hit test.

While it can be fixed by setting the position properly, this is a good opportunity to remove it. I mentioned in previous issue that we want embedder that could control and handle more stuff by itself. Setting should be one of them. Unless the embedder explicitly moves the mouse or other event it prefers to, the compositor shouldn't perform a hit test.

Wdyt? Is it okay to remove it? Or we just set the position?

@wusyong wusyong added B-feature-tracking This issue tracks a particular high-level feature C-untriaged New issues that haven't been triaged yet labels Jun 27, 2024
@sagudev sagudev added A-embedding and removed C-untriaged New issues that haven't been triaged yet labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-embedding B-feature-tracking This issue tracks a particular high-level feature
Projects
None yet
2 participants