-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take the prefix from createElementNS into account for HTML elements #3575
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/2769 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
There's a lot of files but for most of them (all the HTML*Element) the changes is almost identical and only consist of adding a new parameter to the constructor and passing it in. |
Needs a rebase, unfortunately. |
It's my bad, I see the failures are in WPT, I have always run ref and content. |
Yep, your change fixed a bunch failing tests. My favourite kind of problem. |
I removed the expected fails in tests/wpt/metadata/dom/nodes/case.html.ini and rebased. Took a while because I haven't been able to run a subset of the wpt tests and they take over 30 minutes to run. |
Haven't been able to? Even with |
It looks like you should be able to remove the ini file altogether since there are no expected failures. |
Fixes #3139