Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-azure target doesn't depend on libskia.a #472

Closed
metajack opened this issue May 22, 2013 · 4 comments
Closed

rust-azure target doesn't depend on libskia.a #472

metajack opened this issue May 22, 2013 · 4 comments
Labels
E-less-complex Straightforward. Recommended for a new contributor. I-bustage The effect of the issue remaining unresolved. I-papercut Small but painful.

Comments

@metajack
Copy link
Contributor

If you change Skia it does not force rust-azure to be re-linked, although it will force a relink of Servo.
@aydinkim
Copy link

Since there is no libskia-related code in makefile of rust-azure so that the makefile cannot realize the skia's change.
I think codes in linkhack is insufficient for automated building.
If I add some dummy code in makefile of rust-azure, It could be solved.
After some experiments, I'll commit the modification.

@kmcallister
Copy link
Contributor

I got bit by this recently :/ Debug changes in Skia had no effect until I ran make clean-rust-azure.

@zmike
Copy link
Contributor

zmike commented Jan 8, 2014

I put up a PR against rust-azure which fixed this in my testing

@zmike zmike mentioned this issue Jan 14, 2014
Closed
zmike pushed a commit to zmike/servo that referenced this issue Jan 16, 2014
update rust-azure submodule pointer related to servo#472
bf28b1a
therealglazou pushed a commit to therealglazou/servo that referenced this issue Feb 20, 2014
@therealglazou
update rust-azure submodule pointer related to servo#472
01a3593
@jdm jdm mentioned this issue Apr 17, 2014
Closed
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
@Ms2ger
Merge pull request servo#472 from xiaojunwu/submission/xiaojunwu/docu…
0f8556c 
…ment-base-url

Add tests for document base URL; r=denis
@jdm
Copy link
Member

jdm commented Nov 22, 2014

This was fixed with the introduction of cargo.

@jdm jdm closed this as completed Nov 22, 2014
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
Auto merge of servo#472 - vvuk:master, r=glennw
3b62d14 
Add runtime profiler toggle and expose DebugRenderer

This is a bit of a hack, so let me know if you'd prefer me to not do this, or do this a different way.  I'm using this in https://github.com/vvuk/wrench/commit/0747956617902b0ea5c1cb14463c07cd5004bb7c to provide on-screen help and toggle the profiler at runtime.    Toggling the profiler seems to work well.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/472)
<!-- Reviewable:end -->
@jdm jdm mentioned this issue Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-less-complex Straightforward. Recommended for a new contributor. I-bustage The effect of the issue remaining unresolved. I-papercut Small but painful.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jdm @metajack @zmike @kmcallister @aydinkim