Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in tests/reftests.rs #5158

Closed
SimonSapin opened this issue Mar 5, 2015 · 3 comments · Fixed by #5177
Closed

Fix warnings in tests/reftests.rs #5158

SimonSapin opened this issue Mar 5, 2015 · 3 comments · Fixed by #5177
Labels
C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness.

Comments

@SimonSapin
Copy link
Member

E.g. use indexing with ranges instead of slice_from, etc.
@jdm jdm added E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness. labels Mar 5, 2015
@jdm
Copy link
Member

jdm commented Mar 5, 2015

touch tests/reftest.rs && ./mach test-ref will cause the warnings to appear.

@PeterReid PeterReid mentioned this issue Mar 8, 2015
Merged
@wldcordeiro
Copy link
Contributor

I'll take this issue.

@tetsuharuohzeki
Copy link
Contributor

@wldcordeiro this already has been taken by @PeterReid.

@tetsuharuohzeki tetsuharuohzeki added the C-assigned There is someone working on resolving the issue label Mar 10, 2015
bors-servo pushed a commit that referenced this issue Mar 13, 2015
auto merge of #5177 : PeterReid/servo/issue5158, r=jdm
1a96798 
Fixes #5158 

Part of this involved switching to OsStrings for process arguments. Those now interface awkwardly with some remaining use old_io, but that will only be needed until rustc is newer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix warnings in tests/reftest.rs PeterReid/servo
4 participants
@jdm @tetsuharuohzeki @SimonSapin @wldcordeiro