Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use box syntax instead of Box::new() #5422

Merged
merged 1 commit into from
Mar 29, 2015
Merged

Use box syntax instead of Box::new() #5422

merged 1 commit into from
Mar 29, 2015

Conversation

bdero
Copy link
Contributor

@bdero bdero commented Mar 27, 2015

Closes #5417

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

@Ms2ger Ms2ger closed this Mar 28, 2015
@Ms2ger Ms2ger reopened this Mar 28, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4419

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm jdm added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 28, 2015
bors-servo pushed a commit that referenced this pull request Mar 28, 2015
auto merge of #5422 : bdero/servo/bdero/box-syntax, r=Ms2ger
2cb476c 
Closes #5417
@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 28, 2015

ports/gonk/ needs a feature gate

@Ms2ger Ms2ger added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 28, 2015
@bdero
Copy link
Contributor Author

bdero commented Mar 29, 2015

Whoops, just added one. Unfortunately, I can't build gonk locally, so I can't verify.

@Ms2ger Ms2ger added S-needs-squash Some (or all) of the commits in the PR should be combined. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Mar 29, 2015
@jdm
Copy link
Member

jdm commented Mar 29, 2015

Go ahead and squash those together.

@bdero
Copy link
Contributor Author

bdero commented Mar 29, 2015

All set

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-needs-squash Some (or all) of the commits in the PR should be combined. labels Mar 29, 2015
bors-servo pushed a commit that referenced this pull request Mar 29, 2015
auto merge of #5422 : bdero/servo/bdero/box-syntax, r=jdm
9f369a2 
Closes #5417
bors-servo pushed a commit that referenced this pull request Mar 29, 2015
auto merge of #5422 : bdero/servo/bdero/box-syntax, r=jdm
39556cc 
Closes #5417
@bors-servo bors-servo closed this Mar 29, 2015
@bors-servo bors-servo merged commit ccc55d6 into servo:master Mar 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace all instances of Box::new(foo) with box foo
6 participants
@bdero @highfive @hoppipolla-critic-bot @Ms2ger @jdm @bors-servo