Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup script::dom::cssstyledeclarations #5451

Closed
wants to merge 1 commit into from
Closed

Cleanup script::dom::cssstyledeclarations #5451

wants to merge 1 commit into from

Conversation

frewsxcv
Copy link
Contributor

  • Group imports
  • Convert seralization helper function to use Iterator::fold
  • Remove basically pointless serialize_value helper function
  • Wrap lines longer than 100 chars
  • Add URLs to spec

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4440

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm jdm added the S-awaiting-review There is new code that needs to be reviewed. label Mar 30, 2015
@Ms2ger Ms2ger added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 30, 2015
@frewsxcv
Copy link
Contributor Author

@Ms2ger addressed your comments

@jdm jdm added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Mar 30, 2015
@Ms2ger Ms2ger added S-needs-squash Some (or all) of the commits in the PR should be combined. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 30, 2015
@frewsxcv
Cleanup script::dom::cssstyledeclarations
86c254a 
* Group imports
* Convert seralization helper function to use `Iterator::fold`
* Remove basically pointless `serialize_value` helper function
* Wrap lines longer than 100 chars
* Add URLs to spec
@frewsxcv frewsxcv force-pushed the cleanup-css-style-declarations branch from 145fe12 to 86c254a Compare March 30, 2015 16:38
@frewsxcv
Copy link
Contributor Author

@Manishearth @Ms2ger squashed

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-needs-squash Some (or all) of the commits in the PR should be combined. labels Mar 30, 2015
bors-servo pushed a commit that referenced this pull request Mar 30, 2015
auto merge of #5451 : frewsxcv/servo/cleanup-css-style-declarations, …
018e1f7 
…r=Ms2ger

* Group imports
* Convert seralization helper function to use `Iterator::fold`
* Remove basically pointless `serialize_value` helper function
* Wrap lines longer than 100 chars
* Add URLs to spec
@bors-servo bors-servo closed this Mar 30, 2015
@frewsxcv frewsxcv deleted the cleanup-css-style-declarations branch October 9, 2015 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @hoppipolla-critic-bot @jdm @bors-servo @Ms2ger