Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Blob::read_out_bytes always send a vector #6764

Closed
jdm opened this issue Jul 25, 2015 · 2 comments
Closed

Make Blob::read_out_bytes always send a vector #6764

jdm opened this issue Jul 25, 2015 · 2 comments
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.

Comments

@jdm
Copy link
Member

jdm commented Jul 25, 2015

The fact that there may be a None value internally is not important to consumers. We should send an empty vector if there is none stored in the blob.

Code: components/script/dom/blob.rs
@jdm jdm added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. labels Jul 25, 2015
@jdm
Copy link
Member Author

jdm commented Jul 25, 2015

Specifically, the channel used should be a Vec<u8>, not Option<Vec<u8>>.

@notriddle
Copy link
Contributor

✋ I'd like to try this one.

@notriddle notriddle mentioned this issue Jul 26, 2015
Merged
@jdm jdm added the C-assigned There is someone working on resolving the issue label Jul 27, 2015
bors-servo pushed a commit that referenced this issue Jul 28, 2015
Auto merge of #6782 - notriddle:empty-vec, r=jdm
147013a 
Use empty Vec instead of None.

Closes #6764

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6782)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jul 28, 2015
Auto merge of #6782 - notriddle:empty-vec, r=jdm
2672f2b 
Use empty Vec instead of None.

Closes #6764

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6782)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @notriddle