Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use empty Vec instead of None. #6782

Merged
merged 1 commit into from Jul 28, 2015
Merged

Use empty Vec instead of None. #6782

merged 1 commit into from Jul 28, 2015

Conversation

notriddle
Copy link
Contributor

Closes #6764

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 26, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5665

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented Jul 27, 2015

@bors-servo: r+

Thanks for the patch!

@bors-servo
Copy link
Contributor

📌 Commit 5726166 has been approved by jdm

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 27, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 5726166 with merge 147013a...

bors-servo pushed a commit that referenced this pull request Jul 28, 2015
Auto merge of #6782 - notriddle:empty-vec, r=jdm
147013a 
Use empty Vec instead of None.

Closes #6764

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6782)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac1

@jdm
Copy link
Member

jdm commented Jul 28, 2015

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 5726166 with merge 2672f2b...

bors-servo pushed a commit that referenced this pull request Jul 28, 2015
Auto merge of #6782 - notriddle:empty-vec, r=jdm
2672f2b 
Use empty Vec instead of None.

Closes #6764

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6782)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3

@bors-servo bors-servo merged commit 5726166 into servo:master Jul 28, 2015
@bors-servo bors-servo mentioned this pull request Jul 28, 2015
Closed
@notriddle notriddle deleted the empty-vec branch July 29, 2015 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@notriddle @hoppipolla-critic-bot @jdm @bors-servo @highfive