Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WebSocket::Send_Impl. #8345

Closed
Ms2ger opened this issue Nov 5, 2015 · 1 comment
Closed

Rename WebSocket::Send_Impl. #8345

Ms2ger opened this issue Nov 5, 2015 · 1 comment
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 5, 2015

Rust style would be send_impl. Code is in components/script/dom/websocket.rs.
@Ms2ger Ms2ger added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring. labels Nov 5, 2015
@nox
Copy link
Contributor

nox commented Nov 5, 2015

IMO, this should just be send.

@r-52 r-52 mentioned this issue Nov 8, 2015
Merged
bors-servo pushed a commit that referenced this issue Nov 8, 2015
Auto merge of #8408 - romankl:websocket-rename-impl, r=jdm
9bcae9a 
rename WebSocket::Send_Impl

Previos: `Send_Impl`, now: `send_impl`.

Closes: #8345

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8408)
<!-- Reviewable:end -->
@frewsxcv frewsxcv mentioned this issue Nov 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ms2ger @nox