-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit our supported image formats. #8406
Labels
A-content/images
Interacting with images from web content
C-assigned
There is someone working on resolving the issue
Comments
This may be an oversimplification, but could this possibly be handled in the following way? In if buffer.is_empty() {
return None;
}
if (format_not_supported(buffer) {
debug!("Image format not supported."); // should include img format in debug message
return None;
} |
That sounds like the right way to do it! |
Do you mind if I take a stab at this (hopefully later today)? |
Please do! |
bors-servo
pushed a commit
that referenced
this issue
Nov 17, 2015
…=mbrubeck Adding method to detect if image formats should be supported by servo #8406 Please let me know if I need to make any changes. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8503) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this issue
Jun 12, 2017
…be supported by servo (from craftytrickster:8406/limit-suppported-format); r=mbrubeck servo/servo#8406 Please let me know if I need to make any changes. Source-Repo: https://github.com/servo/servo Source-Revision: f17f89059a3681b7bd2da0a04259353ca21c8122
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 1, 2019
…be supported by servo (from craftytrickster:8406/limit-suppported-format); r=mbrubeck servo/servo#8406 Please let me know if I need to make any changes. Source-Repo: https://github.com/servo/servo Source-Revision: f17f89059a3681b7bd2da0a04259353ca21c8122 UltraBlame original commit: 9aa9b1dc7569157249ba77fae193b85cc2d0ae3d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 1, 2019
…be supported by servo (from craftytrickster:8406/limit-suppported-format); r=mbrubeck servo/servo#8406 Please let me know if I need to make any changes. Source-Repo: https://github.com/servo/servo Source-Revision: f17f89059a3681b7bd2da0a04259353ca21c8122 UltraBlame original commit: 9aa9b1dc7569157249ba77fae193b85cc2d0ae3d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 1, 2019
…be supported by servo (from craftytrickster:8406/limit-suppported-format); r=mbrubeck servo/servo#8406 Please let me know if I need to make any changes. Source-Repo: https://github.com/servo/servo Source-Revision: f17f89059a3681b7bd2da0a04259353ca21c8122 UltraBlame original commit: 9aa9b1dc7569157249ba77fae193b85cc2d0ae3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-content/images
Interacting with images from web content
C-assigned
There is someone working on resolving the issue
Prompted by #8392. We should not allow websites to use just any image format that piston happens to support. Support for any image format is a web compatibility decision that should be made as such.
The text was updated successfully, but these errors were encountered: