Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled webgl tests in web-platform-tests due to unimplemented APIs #8462

Closed
simartin opened this issue Nov 11, 2015 · 5 comments · Fixed by servo/gleam#50
Closed

Disabled webgl tests in web-platform-tests due to unimplemented APIs #8462

simartin opened this issue Nov 11, 2015 · 5 comments · Fixed by servo/gleam#50
Labels
A-content/webgl 3d canvas API C-assigned There is someone working on resolving the issue

Comments

@simartin
Copy link
Contributor

Fixing #8413 highlighted that the following APIs are missing in our WebGL implementation: compressedTexImage2D, compressedTexSubImage2D and bufferSubData. A good basis for adding them can be found in #5820

I'm willing to work on this
@jdm jdm added A-content/webgl 3d canvas API C-assigned There is someone working on resolving the issue labels Nov 11, 2015
@jdm
Copy link
Member

jdm commented Nov 11, 2015

cc @ecoal95 to make sure that you're not already working on these ones.

@emilio
Copy link
Member

emilio commented Nov 11, 2015

No, I'm not, take it please!

Feel free to ask me for any info you might need @simartin :)

@simartin simartin mentioned this issue Nov 14, 2015
Merged
@simartin
Copy link
Contributor Author

Grrr, it looks like I should not have referenced this issue in my patch to gleam... Is there any way to reopen this issue (it's not finished) or do I need to open a separate one?

@glennw glennw reopened this Nov 16, 2015
@glennw
Copy link
Member

glennw commented Nov 16, 2015

@simartin Reopened :)

simartin added a commit to simartin/servo that referenced this issue Nov 28, 2015
@simartin
Issue servo#8462: Add support for BufferSubData, CompressedTexImage2D…
760e498 
… and

CompressedSubTexImage2D and unskip individual webgl wpt tests.
simartin added a commit to simartin/servo that referenced this issue Nov 28, 2015
@simartin
Issue servo#8462: Add support for BufferSubData, CompressedTexImage2D…
efab0fc 
… and

CompressedSubTexImage2D and re-enable individual webgl WPT tests.
@simartin simartin mentioned this issue Nov 28, 2015
Merged
simartin added a commit to simartin/servo that referenced this issue Nov 28, 2015
@simartin
Issue servo#8462: Add support for BufferSubData, CompressedTexImage2D…
8527b7e 
… and

CompressedSubTexImage2D and re-enable individual webgl WPT tests.
simartin added a commit to simartin/servo that referenced this issue Nov 29, 2015
@simartin
Issue servo#8462: Add support for BufferSubData, CompressedTexImage2D…
4fc66c7 
… and

CompressedSubTexImage2D and re-enable individual webgl WPT tests.
@dzbarsky
Copy link
Contributor

Well that's annoying.

@dzbarsky dzbarsky reopened this Nov 30, 2015
simartin added a commit to simartin/servo that referenced this issue Dec 1, 2015
@simartin
Issue servo#8462: Add support for BufferSubData, CompressedTexImage2D…
8f4b628 
… and

CompressedSubTexImage2D and re-enable individual webgl WPT tests.
simartin added a commit to simartin/servo that referenced this issue Dec 1, 2015
@simartin
Issue servo#8462: Add support for BufferSubData, CompressedTexImage2D…
ad93f95 
… and

CompressedSubTexImage2D and re-enable individual webgl WPT tests.
simartin added a commit to simartin/servo that referenced this issue Dec 1, 2015
@simartin
Issue servo#8462: Add support for BufferSubData, CompressedTexImage2D…
f79e152 
… and

CompressedSubTexImage2D and re-enable individual webgl WPT tests.
bors-servo pushed a commit that referenced this issue Dec 3, 2015
Auto merge of #8712 - simartin:issue_8462, r=ecoal95
5ee6fe1 
Issue #8462: Add support for BufferSubData, CompressedTexImage2D and CompressedSubTexImage2D and reenable individual webgl WPT tests

Fixes #8462

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8712)
<!-- Reviewable:end -->
@jdm jdm mentioned this issue Jan 4, 2017
Merged
bors-servo pushed a commit that referenced this issue Jan 4, 2017
Auto merge of #14836 - jdm:enable-webgl-test, r=cbrewster
220e6e4 
Enable uniformMatrixNfv.html

Fixes #10478, since #8462 was fixed a while ago.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14836)
<!-- Reviewable:end -->
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this issue Jun 12, 2017
@simartin
servo: Merge #8712 - Issue #8462: Add support for BufferSubData, Comp…
6f3f4b1 
…ressedTexImage2D and CompressedSubTexImage2D and reenable individual webgl WPT tests (from simartin:issue_8462); r=ecoal95

Fixes servo/servo#8462

Source-Repo: https://github.com/servo/servo
Source-Revision: 5ee6fe120d43506e263cb4482b3a468d967a8386
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #8712 - Issue #8462: Add support for BufferSubData, Comp…
336fc62 
…ressedTexImage2D and CompressedSubTexImage2D and reenable individual webgl WPT tests (from simartin:issue_8462); r=ecoal95

Fixes servo/servo#8462

Source-Repo: https://github.com/servo/servo
Source-Revision: 5ee6fe120d43506e263cb4482b3a468d967a8386

UltraBlame original commit: a97a4ba06241d98551eadc74dc5517df8613295e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #8712 - Issue #8462: Add support for BufferSubData, Comp…
66e1a37 
…ressedTexImage2D and CompressedSubTexImage2D and reenable individual webgl WPT tests (from simartin:issue_8462); r=ecoal95

Fixes servo/servo#8462

Source-Repo: https://github.com/servo/servo
Source-Revision: 5ee6fe120d43506e263cb4482b3a468d967a8386

UltraBlame original commit: a97a4ba06241d98551eadc74dc5517df8613295e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #8712 - Issue #8462: Add support for BufferSubData, Comp…
dfc36b0 
…ressedTexImage2D and CompressedSubTexImage2D and reenable individual webgl WPT tests (from simartin:issue_8462); r=ecoal95

Fixes servo/servo#8462

Source-Repo: https://github.com/servo/servo
Source-Revision: 5ee6fe120d43506e263cb4482b3a468d967a8386

UltraBlame original commit: a97a4ba06241d98551eadc74dc5517df8613295e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/webgl 3d canvas API C-assigned There is someone working on resolving the issue
Projects
None yet
Milestone
No milestone
5 participants
@jdm @simartin @emilio @dzbarsky @glennw