Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Get Element Attribute WebDriver command #8564

Merged
merged 1 commit into from Nov 19, 2015
Merged

Implement Get Element Attribute WebDriver command #8564

merged 1 commit into from Nov 19, 2015

Conversation

jgraham
Copy link
Contributor

@jgraham jgraham commented Nov 17, 2015

This intentionally doesn't implement the special handling for boolean
attributes yet, since that requires some kind of exhaustive list of all
such attributes

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 17, 2015
@frewsxcv frewsxcv added S-fails-tidy `./mach test-tidy` reported errors. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 17, 2015
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 18, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 19, 2015

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 6446cc3 has been approved by Ms2ger

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 19, 2015
@jdm jdm removed the S-fails-tidy `./mach test-tidy` reported errors. label Nov 19, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 6446cc3 with merge 7f95693...

bors-servo pushed a commit that referenced this pull request Nov 19, 2015
Auto merge of #8564 - jgraham:webdriver_attr, r=Ms2ger
7f95693 
Implement Get Element Attribute WebDriver command

This intentionally doesn't implement the special handling for boolean
attributes yet, since that requires some kind of exhaustive list of all
such attributes

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8564)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 6446cc3 into servo:master Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jgraham @Ms2ger @bors-servo @jdm @frewsxcv @highfive