Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the structs, enums, and fields in query.rs private. #8620

Closed
Ms2ger opened this issue Nov 20, 2015 · 2 comments
Closed

Make the structs, enums, and fields in query.rs private. #8620

Ms2ger opened this issue Nov 20, 2015 · 2 comments
Labels
A-layout/uncategorized C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 20, 2015

Code is in components/layout/query.rs. There's a number of public structs, enums, and fields that are implementation details for the functions that are used in layout_task.rs. Everything that isn't used outside the file should be made private, by removing the pub keywords.
@Ms2ger Ms2ger added A-layout/uncategorized E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring. labels Nov 20, 2015
@jmr0
Copy link
Contributor

jmr0 commented Nov 20, 2015

I'd be happy to take on this one

@jdm jdm added the C-assigned There is someone working on resolving the issue label Nov 20, 2015
@jdm
Copy link
Member

jdm commented Nov 20, 2015

Go for it!

@jmr0 jmr0 mentioned this issue Nov 22, 2015
Merged
bors-servo pushed a commit that referenced this issue Nov 22, 2015
Auto merge of #8642 - jmr0:master, r=jdm
4dbd3df 
making internal pub enums, functions, and structs private

Refactoring to fix #8620

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8642)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Nov 22, 2015
Auto merge of #8642 - jmr0:master, r=jdm
3199eac 
making internal pub enums, functions, and structs private

Refactoring to fix #8620

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8642)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/uncategorized C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdm @Ms2ger @jmr0