Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser API: HTTP redirect doesn't trigger a locationchange event #8902

Closed
paulrouget opened this issue Dec 9, 2015 · 1 comment
Closed

Browser API: HTTP redirect doesn't trigger a locationchange event #8902

paulrouget opened this issue Dec 9, 2015 · 1 comment
Labels
A-constellation Involves the constellation A-network

Comments

@paulrouget
Copy link
Contributor

locationchange events are triggered from constellation.rs.

Redirects happen in http_loader.rs (in the loop in the load function).

We could just send a locationchange event once the whole document is loaded (from document.rs), but ideally, we'd like to get an event every time a redirect happens, and before the load event. So we need to be able to send a message to the constellation from http_loader.

Does that make sense? If so, how to reach the constellation channel from within http_loader?
@paulrouget paulrouget mentioned this issue Dec 9, 2015
Closed
92 tasks
@jdm jdm added A-network A-constellation Involves the constellation labels Dec 9, 2015
@paulrouget
Copy link
Contributor Author

Gecko doesn't send locationchange during redirects.

So this should be fixed once #9164 lands.

@paulrouget paulrouget mentioned this issue Jan 6, 2016
Merged
bors-servo pushed a commit that referenced this issue Jan 6, 2016
Auto merge of #9164 - paulrouget:updatePipelineURL, r=jdm
f4a2fe9 
update pipeline url after redirections

`pipeline.url` is not updated after a redirection.

Fixes #8902

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9164)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-constellation Involves the constellation A-network
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @paulrouget