-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unexpected overflow #9306
Comments
I can reproduce this bug with the following smaller code:
I think the problem is that negative margins are accumulated into the overflow rectangle, which is then used to determine whether a region is scrollable or not. I think Patrick mentioned something a while ago about Gecko having separate concepts for visual overflow vs. scrollable overflow - would that be relevant here? @pcwalton How should we handle this case in layout? |
If negative margins are accumulated into the overflow rect, then that should be easily fixable. |
There are actually two bugs here. One, which @glennw's test case displays, is that |
It looks like the second bug is an incremental reflow bug relating to inline absolute hypothetical fragments. |
absolutely-positioned flows separately when storing overflow. This code dates back to the time when absolutely positioned flows were ignored by all of their ancestors up to the containing block. This hasn't been true for at least a year. Closes servo#9306. Closes servo#9309. Is a partial fix for servo#9308.
layout: Remove some bogus code that tried to handle absolutely-positioned flows separately when storing overflow. This code dates back to the time when absolutely positioned flows were ignored by all of their ancestors up to the containing block. This hasn't been true for at least a year. Closes #9306. Closes #9309. Is a partial fix for #9308. r? @glennw <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9405) <!-- Reviewable:end -->
absolutely-positioned flows separately when storing overflow. This code dates back to the time when absolutely positioned flows were ignored by all of their ancestors up to the containing block. This hasn't been true for at least a year. Closes servo#9306. Closes servo#9309. Is a partial fix for servo#9308.
layout: Remove some bogus code that tried to handle absolutely-positioned flows separately when storing overflow. This code dates back to the time when absolutely positioned flows were ignored by all of their ancestors up to the containing block. This hasn't been true for at least a year. Closes #9306. Closes #9309. Is a partial fix for #9308. r? @glennw <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9405) <!-- Reviewable:end -->
The following example makes the body element scrollable. The extra area is apparently directly related to the horizontal padding.
The text was updated successfully, but these errors were encountered: