Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unexpected overflow with display:inline-block + margin #9308

Closed
paulrouget opened this issue Jan 14, 2016 · 1 comment
Closed

unexpected overflow with display:inline-block + margin #9308

paulrouget opened this issue Jan 14, 2016 · 1 comment
Labels
A-layout/block A-layout/inline

Comments

@paulrouget
Copy link
Contributor

rggdhwjnub

The following example makes the body element scrollable. The extra area is apparently directly related to the margin value.

Note: using block instead of inline-block reduces the scrollable area, but it's still possible to scroll.

<div style="left: 0px; bottom: 0px; position: absolute;">
  <div style="margin: 200px; display: inline-block; background: red">foobar</div>
</div>
@paulrouget paulrouget mentioned this issue Jan 14, 2016
Closed
92 tasks
This was referenced Jan 18, 2016
Closed
Closed
pcwalton added a commit to pcwalton/servo that referenced this issue Jan 23, 2016
@pcwalton
layout: Remove some bogus code that tried to handle
d81d1df 
absolutely-positioned flows separately when storing overflow.

This code dates back to the time when absolutely positioned flows were
ignored by all of their ancestors up to the containing block. This
hasn't been true for at least a year.

Closes servo#9306.
Closes servo#9309.
Is a partial fix for servo#9308.
@pcwalton pcwalton mentioned this issue Jan 23, 2016
Merged
bors-servo pushed a commit that referenced this issue Jan 23, 2016
Auto merge of #9405 - pcwalton:absolute-positioning-overflow, r=glennw
3061d50 
layout: Remove some bogus code that tried to handle absolutely-positioned flows separately when storing overflow.

This code dates back to the time when absolutely positioned flows were
ignored by all of their ancestors up to the containing block. This
hasn't been true for at least a year.

Closes #9306.
Closes #9309.
Is a partial fix for #9308.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9405)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Jan 25, 2016
@pcwalton
layout: Remove some bogus code that tried to handle
9c7b9fa 
absolutely-positioned flows separately when storing overflow.

This code dates back to the time when absolutely positioned flows were
ignored by all of their ancestors up to the containing block. This
hasn't been true for at least a year.

Closes servo#9306.
Closes servo#9309.
Is a partial fix for servo#9308.
bors-servo pushed a commit that referenced this issue Jan 25, 2016
Auto merge of #9405 - pcwalton:absolute-positioning-overflow, r=glennw
4755cc5 
layout: Remove some bogus code that tried to handle absolutely-positioned flows separately when storing overflow.

This code dates back to the time when absolutely positioned flows were
ignored by all of their ancestors up to the containing block. This
hasn't been true for at least a year.

Closes #9306.
Closes #9309.
Is a partial fix for #9308.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9405)
<!-- Reviewable:end -->
@pcwalton
Copy link
Contributor

Smaller test case:

<!DOCTYPE html>
hello

Shouldn't scroll.

The problem goes away if margins on the document element are set to zero.

pcwalton added a commit to pcwalton/servo that referenced this issue Jan 27, 2016
@pcwalton
Expand the block size of the root flow's margin box to the viewport size
0d2428c 
instead of expanding the block size of its border box.

Closes servo#9308.
@pcwalton pcwalton mentioned this issue Jan 27, 2016
Merged
pcwalton added a commit to pcwalton/servo that referenced this issue Jan 27, 2016
@pcwalton
Expand the block size of the root flow's margin box to the viewport size
ce1dd57 
instead of expanding the block size of its border box.

Closes servo#9308.
pcwalton added a commit to pcwalton/servo that referenced this issue Jan 27, 2016
@pcwalton
Expand the block size of the root flow's margin box to the viewport size
2332fd5 
instead of expanding the block size of its border box.

Closes servo#9308.
bors-servo pushed a commit that referenced this issue Jan 27, 2016
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
fe4e7f5 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 28, 2016
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
35efe7b 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Jan 28, 2016
@pcwalton
Expand the block size of the root flow's margin box to the viewport size
777c46f 
instead of expanding the block size of its border box.

Closes servo#9308.
bors-servo pushed a commit that referenced this issue Jan 28, 2016
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
ae6b503 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 28, 2016
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
430123f 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 29, 2016
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
c8dfe16 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 29, 2016
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
d1ff330 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/block A-layout/inline
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pcwalton @paulrouget @frewsxcv