gfx: Simplify complex clipping regions as we construct them. #10331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
@paulrouget This is not a complete fix, but it fixes your test case. Let me know if you need to handle more cases than this right now. |
This allows WebRender to correctly render complex clipping regions that can be reduced to single rounded rectangles. WebRender still can't render rounded rectangles with arbitrary intersections yet, but this allows it to handle many more cases. Closes servo/webrender#241.
|
@bors-servo r+ |
|
📌 Commit 22a1c11 has been approved by |
highfive
added
S-awaiting-merge
Tested. It fixes our issues in browserhtml. So that's enough. Thank you. |
|
⌛ Testing commit 22a1c11 with merge 4e21517... |
bors-servo
pushed a commit
that referenced
this pull request
Apr 1, 2016
…glennw gfx: Simplify complex clipping regions as we construct them. This allows WebRender to correctly render complex clipping regions that can be reduced to single rounded rectangles. WebRender still can't render rounded rectangles with arbitrary intersections yet, but this allows it to handle many more cases. Closes servo/webrender#241. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10331) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows WebRender to correctly render complex clipping regions that
can be reduced to single rounded rectangles. WebRender still can't
render rounded rectangles with arbitrary intersections yet, but this
allows it to handle many more cases.
Closes servo/webrender#241.
r? @glennw
This change is