Use xi-unicode for line breaking #10913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
highfive
added
the
S-awaiting-review
mbrubeck
added
A-layout/text
and removed
S-awaiting-review
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Apr 29, 2016
Use xi-unicode for line breaking This uses the xi-unicode crate by @raphlinus to detect line-break opportunities, replacing Servo's custom code that only detects ASCII whitespace. xi-unicode is licensed under the Apache-2.0 license. See mbrubeck#2 for some discussion on an earlier draft of this code. This PR implements the "search backward to find trailing whitespace" solution discussed there. Note: I'll need to update test expectations after a "try" run. r? @pcwalton <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10913) <!-- Reviewable:end -->
|
💔 Test failed - linux-dev |
nox
added
S-fails-tidy
|
highfive
added
the
S-awaiting-review
Fixed. |
|
Nice! Looks great. |
|
@bors-servo: r+ |
|
📌 Commit 5834659 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Apr 30, 2016
Use xi-unicode for line breaking This uses the xi-unicode crate by @raphlinus to detect line-break opportunities, replacing Servo's custom code that only detects ASCII whitespace. xi-unicode is licensed under the Apache-2.0 license. See mbrubeck#2 for some discussion on an earlier draft of this code. This PR implements the "search backward to find trailing whitespace" solution discussed there. r? @pcwalton <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10913) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-css |
highfive
added
S-tests-failed
|
|
That's a pretty impressive set of results! 👏 |
bors-servo
pushed a commit
that referenced
this pull request
Apr 30, 2016
Use xi-unicode for line breaking This uses the xi-unicode crate by @raphlinus to detect line-break opportunities, replacing Servo's custom code that only detects ASCII whitespace. xi-unicode is licensed under the Apache-2.0 license. See mbrubeck#2 for some discussion on an earlier draft of this code. This PR implements the "search backward to find trailing whitespace" solution discussed there. r? @pcwalton <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10913) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-css |
highfive
added
S-tests-failed
|
@bors-servo retry
|
|
⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit are reusable. Rebuilding only android, linux-rel, mac-rel-css, mac-rel-wpt, windows... |
|
💔 Test failed - mac-rel-css |
|
@bors-servo retry
|
|
⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-wpt are reusable. Rebuilding only mac-rel-css, windows... |
|
💔 Test failed - mac-rel-css |
|
highfive
added
S-awaiting-review
|
@bors-servo r=pcwalton
|
|
📌 Commit 894f639 has been approved by |
highfive
added
S-awaiting-merge
|
⌛ Testing commit 894f639 with merge fc1e4c8... |
bors-servo
pushed a commit
that referenced
this pull request
May 1, 2016
Use xi-unicode for line breaking This uses the xi-unicode crate by @raphlinus to detect line-break opportunities, replacing Servo's custom code that only detects ASCII whitespace. xi-unicode is licensed under the Apache-2.0 license. See mbrubeck#2 for some discussion on an earlier draft of this code. This PR implements the "search backward to find trailing whitespace" solution discussed there. r? @pcwalton <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10913) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the xi-unicode crate by @raphlinus to detect line-break opportunities, replacing Servo's custom code that only detects ASCII whitespace. xi-unicode is licensed under the Apache-2.0 license.
See mbrubeck#2 for some discussion on an earlier draft of this code. This PR implements the "search backward to find trailing whitespace" solution discussed there.
r? @pcwalton
This change is