-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to a faster Brotli crate #12050
Conversation
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @KiChjang (or someone else) soon. |
Heads up! This PR modifies the following files:
|
There's an automated test at https://dxr.mozilla.org/servo/source/tests/wpt/mozilla/tests/mozilla/response-data-brotli.htm so we should be good to go. |
@bors-servo: r+ |
📌 Commit bf61d45 has been approved by |
⌛ Testing commit bf61d45 with merge a06317d... |
Switch to a faster Brotli crate <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #11933. <!-- Either: --> - [x] These changes do not require tests (I hope) because no new behavior was introduced <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12050) <!-- Reviewable:end -->
💔 Test failed - linux-dev |
Could you run |
Oh, yes, I missed that one. Updated! Thanks! |
@johannhof no problem, thanks for doing this! |
📌 Commit 7890440 has been approved by |
Switch to a faster Brotli crate <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #11933. <!-- Either: --> - [x] These changes do not require tests (I hope) because no new behavior was introduced <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12050) <!-- Reviewable:end -->
💔 Test failed - linux-rel |
|
@bors-servo force |
@bors-servo retry
|
⌛ Testing commit 7890440 with merge c8b048e... |
Switch to a faster Brotli crate <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #11933. <!-- Either: --> - [x] These changes do not require tests (I hope) because no new behavior was introduced <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12050) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows |
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is