Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse a stable compiler for build-geckolib #12319
Conversation
highfive
commented
Jul 7, 2016
|
Heads up! This PR modifies the following files:
|
|
|
|
Rebased. r? @larsbergstrom |
|
Reviewed 4 of 4 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, 2 of 2 files at r4, 3 of 3 files at r5, 8 of 8 files at r6, 2 of 2 files at r7, 2 of 2 files at r8, 2 of 2 files at r9, 3 of 3 files at r10. python/servo/build_commands.py, line 372 [r3] (raw file):
maybe target/geckolib instead? I'm a little wary of having another target/ dir buried inside the source tree instead of at toplevel. Comments from Reviewable |
|
Feel free to r=me with that change (if you agree), as I'm on PTO today. Otherwise, I'll take a look this weekend :-) Thanks for doing this! |
|
@bors-servo r= larsbergstrom Reviewed 2 of 2 files at r11. python/servo/build_commands.py, line 372 [r3] (raw file):
|
|
|
|
@bors-servo r=larsbergstrom |
|
|
Use a stable compiler for build-geckolib <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #11815 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because CI already runs `./mach build-geckolib` <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12319) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
|
|
|
|
Use a stable compiler for build-geckolib <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #11815 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because CI already runs `./mach build-geckolib` <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12319) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
|
|
|
|
|
@bors-servo r=larsbergstrom+SimonSapin With an extra commit to download std even if rustc is already there. |
|
|
Use a stable compiler for build-geckolib <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #11815 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because CI already runs `./mach build-geckolib` <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12319) <!-- Reviewable:end -->
|
|
Build geckolib with MozillaBuild on Windows <!-- Please describe your changes on the following line: --> Given #12319 removes the direct dependency of geckolib to gcc, geckolib is now compilable without gcc, and thus builds within MozillaBuild. This changeset also changes the triple to use the MSVC backend rather than GNU for Windows . I'm not sure whether this change is necessary, but given we use MSVC to compile Gecko on Windows, I think we would eventually need this anyway. Triples for MinGW64 and Cygwin are unchanged, so that existing build targets should not be broken. Servo itself is still not buildable with MozillaBuild. To make that work, some changes to mozjs are necessary as well. It is probably worth some infra coverage to avoid regression. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors (on MinGW) - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it only changes build system <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> r? @bholley <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12377) <!-- Reviewable:end -->
SimonSapin commentedJul 7, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors./mach build-geckolibThis change is