Run CSS Multicolumn tests automatically #13599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
|
Heads up! This PR modifies the following files:
|
|
@bors-servo: r+ |
|
📌 Commit 37d6725 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Oct 5, 2016
Run CSS Multicolumn tests automatically <!-- Please describe your changes on the following line: --> Implements the CSS multicolumn tests as outlined in issue #13587. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13587 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they implement tests for other features. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13599) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-css |
highfive
added
S-tests-failed
|
Looks like only one change is required - make the expected outcome of multicol-br-inside-avoidcolumn-001.htm (inside |
highfive
added
S-awaiting-review
|
All right, these changes have been made! Sorry about that. |
|
There's no reason to apologize; inconsistent test expectations are a problem with our test harness, not something that you're responsible for :) |
|
📌 Commit 2f6393a has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Oct 5, 2016
Run CSS Multicolumn tests automatically <!-- Please describe your changes on the following line: --> Implements the CSS multicolumn tests as outlined in issue #13587. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13587 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they implement tests for other features. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13599) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-css |
highfive
added
S-tests-failed
|
The manifest files are whitespace-sensitive so you can't have but must instead have the same whitespace: |
|
I'm surprised that the code that checks if the manifests change on TravisCI didn't report any error about that... |
|
Different manifests… it could of course but at the moment it doesn't because we don't read expectation metadata for tests we won't run. |
highfive
added
S-awaiting-review
|
Third time's a charm, hopefully. |
|
@bors-servo: r+ |
|
📌 Commit ec8ade4 has been approved by |
highfive
removed
the
S-awaiting-review
highfive
added
the
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Oct 5, 2016
Run CSS Multicolumn tests automatically <!-- Please describe your changes on the following line: --> Implements the CSS multicolumn tests as outlined in issue #13587. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13587 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they implement tests for other features. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13599) <!-- Reviewable:end -->
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the CSS multicolumn tests as outlined in issue #13587.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is