Don't promote all scrollable regions to stacking contexts #14084

mrobinson · 2016-11-05T17:40:44Z

Don't promote all scrollable regions to stacking contexts

Instead annotate all flows with their owning ScrollRoots. When
processing the display list items into a flattened display list, we add
PushScrollRoot and PopScrollRoot to signal when scrolling regions start
and end. It is possible for content from different scrolling regions to
intersect and when they do, the stack of scrolling regions is
duplicated. When these duplicated scrolling regions stacks reach
WebRender, it will scroll them in tandem.

The PushScrollRoot and PopScrollRoot items are currently represented as
StackingContexts in WebRender, but eventually these will be replaced
with special WebRender display items.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Should be able to interleave scroll frame contents with unscrolled elements from outside the scroll frame #13529 and overflow:auto changes z order #13298. (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because _____

This change is

Instead annotate all flows with their owning ScrollRoots. When processing the display list items into a flattened display list, we add PushScrollRoot and PopScrollRoot to signal when scrolling regions start and end. It is possible for content from different scrolling regions to intersect and when they do, the stack of scrolling regions is duplicated. When these duplicated scrolling regions stacks reach WebRender, it will scroll them in tandem. The PushScrollRoot and PopScrollRoot items are currently represented as StackingContexts in WebRender, but eventually these will be replaced with special WebRender display items. Fixes servo#13529. Fixed servo#13298.

highfive · 2016-11-05T17:40:47Z

Heads up! This PR modifies the following files:

@emilio: components/layout/display_list_builder.rs, components/layout/fragment.rs, components/layout/traversal.rs, components/layout/block.rs, components/layout/webrender_helpers.rs

mrobinson · 2016-11-05T17:40:58Z

@pcwalton or @glennw r?

glennw · 2016-11-05T19:08:20Z

@mrobinson Did any shaders need to be copied across with the WR update?

mrobinson · 2016-11-07T08:12:12Z

@glennw Actually, yes! Some shaders were updated. I was copying them into the wrong checkout of Servo. I'll update the branch.

glennw · 2016-11-07T09:55:02Z

@mrobinson OK, once the shaders are copied across let's issue a try run and I'll review in the morning. Thanks!

glennw · 2016-11-07T09:55:39Z

@bors-servo try

bors-servo · 2016-11-07T09:55:42Z

⌛ Trying commit dea0c7c with merge 67ec102...

Don't promote all scrollable regions to stacking contexts  Don't promote all scrollable regions to stacking contexts Instead annotate all flows with their owning ScrollRoots. When processing the display list items into a flattened display list, we add PushScrollRoot and PopScrollRoot to signal when scrolling regions start and end. It is possible for content from different scrolling regions to intersect and when they do, the stack of scrolling regions is duplicated. When these duplicated scrolling regions stacks reach WebRender, it will scroll them in tandem. The PushScrollRoot and PopScrollRoot items are currently represented as StackingContexts in WebRender, but eventually these will be replaced with special WebRender display items. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13529 and #13298. (github issue number if applicable).  - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14084)

mrobinson · 2016-11-07T10:02:04Z

@glennw Thanks!

emilio · 2016-11-07T19:23:12Z

@bors-servo clear try

bors-servo · 2016-11-07T19:23:43Z

⌛ Trying commit dea0c7c with merge 5145a40...

Don't promote all scrollable regions to stacking contexts  Don't promote all scrollable regions to stacking contexts Instead annotate all flows with their owning ScrollRoots. When processing the display list items into a flattened display list, we add PushScrollRoot and PopScrollRoot to signal when scrolling regions start and end. It is possible for content from different scrolling regions to intersect and when they do, the stack of scrolling regions is duplicated. When these duplicated scrolling regions stacks reach WebRender, it will scroll them in tandem. The PushScrollRoot and PopScrollRoot items are currently represented as StackingContexts in WebRender, but eventually these will be replaced with special WebRender display items. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13529 and #13298. (github issue number if applicable).  - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14084)

bors-servo · 2016-11-07T20:13:15Z

💔 Test failed - mac-rel-wpt2

jdm · 2016-11-07T20:30:07Z

Filed #14118 for the previous failure.

glennw · 2016-11-07T20:35:22Z

@bors-servo retry

Intermittent crash in /_mozilla/css/iframe/size_attributes.html, /_mozilla/css/iframe/size_attributes_vertical_writing_mode.html and /html/semantics/embedded-content/the-iframe-element/iframe-with-base.html #14118

bors-servo · 2016-11-07T20:35:29Z

⌛ Trying commit dea0c7c with merge e18a64e...

Don't promote all scrollable regions to stacking contexts  Don't promote all scrollable regions to stacking contexts Instead annotate all flows with their owning ScrollRoots. When processing the display list items into a flattened display list, we add PushScrollRoot and PopScrollRoot to signal when scrolling regions start and end. It is possible for content from different scrolling regions to intersect and when they do, the stack of scrolling regions is duplicated. When these duplicated scrolling regions stacks reach WebRender, it will scroll them in tandem. The PushScrollRoot and PopScrollRoot items are currently represented as StackingContexts in WebRender, but eventually these will be replaced with special WebRender display items. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13529 and #13298. (github issue number if applicable).  - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14084)

bors-servo · 2016-11-07T22:30:15Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

glennw · 2016-11-07T23:31:54Z

@bors-servo r+

bors-servo · 2016-11-07T23:31:55Z

📌 Commit dea0c7c has been approved by glennw

glennw · 2016-11-07T23:33:08Z

@mrobinson Awesome! The code looks good. We don't have great test coverage for scroll issues, but I tested manually on a number of sites, including browser.html and all seemed good from what I could see.

glennw · 2016-11-07T23:34:55Z

@bors-servo try- r+

bors-servo · 2016-11-07T23:34:57Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: added dom obj counting to decide sequential/parallel layout (#10110) #12862

bors-servo · 2016-11-07T23:34:57Z

📌 Commit dea0c7c has been approved by glennw

glennw · 2016-11-07T23:35:08Z

@bors-servo retry

Don't promote all scrollable regions to stacking contexts  Don't promote all scrollable regions to stacking contexts Instead annotate all flows with their owning ScrollRoots. When processing the display list items into a flattened display list, we add PushScrollRoot and PopScrollRoot to signal when scrolling regions start and end. It is possible for content from different scrolling regions to intersect and when they do, the stack of scrolling regions is duplicated. When these duplicated scrolling regions stacks reach WebRender, it will scroll them in tandem. The PushScrollRoot and PopScrollRoot items are currently represented as StackingContexts in WebRender, but eventually these will be replaced with special WebRender display items. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13529 and #13298. (github issue number if applicable).  - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14084)

bors-servo · 2016-11-08T00:49:54Z

⌛ Testing commit dea0c7c with merge ef5ca14...

bors-servo · 2016-11-08T01:46:17Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

highfive assigned wafflespeanut Nov 5, 2016

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 5, 2016

wafflespeanut assigned pcwalton and glennw and unassigned wafflespeanut Nov 6, 2016

Update WebRender to get necessary changes

dea0c7c

mrobinson force-pushed the scroll_root_2 branch from 1bb487e to dea0c7c Compare November 7, 2016 09:34

bors-servo mentioned this pull request Nov 7, 2016

Enable cors and redirect fetch tests. #14070

Closed

highfive added the S-tests-failed The changes caused existing tests to fail. label Nov 7, 2016

highfive unassigned pcwalton Nov 7, 2016

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-tests-failed The changes caused existing tests to fail. labels Nov 7, 2016

bors-servo merged commit dea0c7c into servo:master Nov 8, 2016

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 8, 2016

mrobinson deleted the scroll_root_2 branch November 8, 2016 10:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't promote all scrollable regions to stacking contexts #14084

Don't promote all scrollable regions to stacking contexts #14084

mrobinson commented Nov 5, 2016 •

edited by larsbergstrom

highfive commented Nov 5, 2016

mrobinson commented Nov 5, 2016

glennw commented Nov 5, 2016

mrobinson commented Nov 7, 2016

glennw commented Nov 7, 2016

glennw commented Nov 7, 2016

bors-servo commented Nov 7, 2016

mrobinson commented Nov 7, 2016

emilio commented Nov 7, 2016 •

edited

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

jdm commented Nov 7, 2016

glennw commented Nov 7, 2016

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

glennw commented Nov 7, 2016

bors-servo commented Nov 7, 2016

glennw commented Nov 7, 2016

glennw commented Nov 7, 2016

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

glennw commented Nov 7, 2016

bors-servo commented Nov 8, 2016

bors-servo commented Nov 8, 2016

Don't promote all scrollable regions to stacking contexts #14084

Don't promote all scrollable regions to stacking contexts #14084

Conversation

mrobinson commented Nov 5, 2016 • edited by larsbergstrom

highfive commented Nov 5, 2016

mrobinson commented Nov 5, 2016

glennw commented Nov 5, 2016

mrobinson commented Nov 7, 2016

glennw commented Nov 7, 2016

glennw commented Nov 7, 2016

bors-servo commented Nov 7, 2016

mrobinson commented Nov 7, 2016

emilio commented Nov 7, 2016 • edited

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

jdm commented Nov 7, 2016

glennw commented Nov 7, 2016

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

glennw commented Nov 7, 2016

bors-servo commented Nov 7, 2016

glennw commented Nov 7, 2016

glennw commented Nov 7, 2016

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

glennw commented Nov 7, 2016

bors-servo commented Nov 8, 2016

bors-servo commented Nov 8, 2016

mrobinson commented Nov 5, 2016 •

edited by larsbergstrom

emilio commented Nov 7, 2016 •

edited