Enable cors and redirect fetch tests. #14070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
@bors-servo: try |
Manishearth
reviewed
Nov 4, 2016
| [Include mode: 1 cookie] | ||
| [Include mode: local cookies are not sent with remote request] | ||
| expected: FAIL | ||
|
|
There was a problem hiding this comment.
this doesn't seem good
(yes, we already failed here before this PR, but we should fix this)
|
r=me if try doesn't turn up anything other than new passes |
|
💔 Test failed - linux-rel-wpt |
|
@bors-servo: try |
bors-servo
pushed a commit
that referenced
this pull request
Nov 4, 2016
Enable cors and redirect fetch tests. There have been a bunch of changes to the fetch code since #13441 was filed, and the results seem more stable now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14070) <!-- Reviewable:end -->
|
💥 Test timed out |
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Nov 5, 2016
Enable cors and redirect fetch tests. There have been a bunch of changes to the fetch code since #13441 was filed, and the results seem more stable now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14070) <!-- Reviewable:end -->
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Nov 5, 2016
Enable cors and redirect fetch tests. There have been a bunch of changes to the fetch code since #13441 was filed, and the results seem more stable now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14070) <!-- Reviewable:end -->
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
|
@bors-servo: r=Manishearth |
|
📌 Commit a2468a4 has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo try- retry clean |
bors-servo
pushed a commit
that referenced
this pull request
Nov 6, 2016
Enable cors and redirect fetch tests. There have been a bunch of changes to the fetch code since #13441 was filed, and the results seem more stable now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14070) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-wpt |
highfive
removed
the
S-awaiting-merge
|
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #13918) made this pull request unmergeable. Please resolve the merge conflicts. |
highfive
added
S-awaiting-review
|
@bors-servo: r=Manishearth |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit a2468a4 has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo: retry |
|
@bors-servo: clean r=Manishearth |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit a2468a4 has been approved by |
|
Closed in favour of #14116. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a bunch of changes to the fetch code since #13441 was filed, and the results seem more stable now.
This change is