Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `./mach clippy`. #14134

Merged
merged 2 commits into from Nov 9, 2016
Merged

Fix `./mach clippy`. #14134

merged 2 commits into from Nov 9, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Nov 8, 2016 •
edited by larsbergstrom

Fixes #13117.

This change is Reviewable
@frewsxcv
Fix `./mach clippy`.
Loading status checks…
04df787 
Fixes #13117.
@highfive
Copy link

highfive commented Nov 8, 2016

Heads up! This PR modifies the following files:
@frewsxcv frewsxcv mentioned this pull request Nov 8, 2016
Closed
@jdm
Copy link
Member

jdm commented Nov 8, 2016 

110.95s$ ./mach test-tidy --no-progress --all
Checking the config file...
Checking directories for correct file extensions...
Checking files for tidiness...
./components/servo/Cargo.lock:1: duplicate versions for package "semver"
    found dependency on version 0.1.20
    but highest version is 0.2.3
    try upgrading with ./mach cargo-update -p semver:0.1.20
    The following packages depend on version 0.1.20:
        rustc_version
@jdm jdm added S-fails-tidy and removed S-awaiting-review labels Nov 8, 2016
@frewsxcv
Add 'semver' crate to mismatched version whitelist.
Loading status checks…
fa8e6c1 
clippy uses semver==0.2.x

rustc-version uses semver==0.1.x

Kimundi/rustc-version-rs#5
@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 8, 2016

Addressed in fa8e6c1.
@jdm
Copy link
Member

jdm commented Nov 8, 2016

@bors-servo: r+
Woo, semver ecosystems.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

📌 Commit fa8e6c1 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2016

⌛ Testing commit fa8e6c1 with merge 16dc3a9...
bors-servo added a commit that referenced this pull request Nov 9, 2016
@bors-servo
Auto merge of #14134 - frewsxcv:cargo-clippy, r=jdm
Loading status checks…
16dc3a9 
Fix `./mach clippy`.

Fixes #13117.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14134)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2016

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented Nov 9, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2016

⌛ Testing commit fa8e6c1 with merge f1f97fb...
bors-servo added a commit that referenced this pull request Nov 9, 2016
@bors-servo
Auto merge of #14134 - frewsxcv:cargo-clippy, r=jdm
Loading status checks…
f1f97fb 
Fix `./mach clippy`.

Fixes #13117.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14134)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit fa8e6c1 into servo:master Nov 9, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:cargo-clippy branch Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-fails-tidy
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@frewsxcv @highfive @jdm @bors-servo
You can’t perform that action at this time.