Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cssparser 0.13 #16589

Merged
merged 1 commit into from Apr 25, 2017
Merged

Update to cssparser 0.13 #16589

merged 1 commit into from Apr 25, 2017

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Apr 24, 2017 •
edited by larsbergstrom

servo/rust-cssparser#140

This change is Reviewable
@highfive
Copy link

highfive commented Apr 24, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/properties/properties.mako.rs
  • @KiChjang: components/script/Cargo.toml, components/script_layout_interface/Cargo.toml
  • @fitzgen: components/script/Cargo.toml, components/script_layout_interface/Cargo.toml
  • @emilio: components/style/Cargo.toml, components/layout/Cargo.toml, ports/geckolib/Cargo.toml, components/style/properties/properties.mako.rs
@emilio
Copy link
Member

emilio commented Apr 24, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

📌 Commit 25de180 has been approved by emilio
@highfive highfive assigned emilio and unassigned KiChjang Apr 24, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

⌛ Testing commit 25de180 with merge 9d6480c...
bors-servo added a commit that referenced this pull request Apr 24, 2017
@bors-servo
Auto merge of #16589 - servo:cssparserup, r=emilio
Loading status checks…
9d6480c 
Update to cssparser 0.13

servo/rust-cssparser#140

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16589)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented Apr 24, 2017 

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-2

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-7

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-8

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-2

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-7

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-8

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-2

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-3.html:
  │ FAIL [expected PASS] Canvas test: 2d.fillStyle.parse.rgb-clamp-3
  │   → assert_equals: Green channel of the pixel at (50, 25) expected 255 but got 0
  │ 
  │ _assertPixel@http://web-platform.test:8000/common/canvas-tests.js:39:5
  │ @http://web-platform.test:8000/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-3.html:26:1
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  │ _addTest/</<@http://web-platform.test:8000/common/canvas-tests.js:62:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  └ _addTest/<@http://web-platform.test:8000/common/canvas-tests.js:59:9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-4.html:
  │ FAIL [expected PASS] Canvas test: 2d.fillStyle.parse.rgb-clamp-4
  │   → assert_equals: Green channel of the pixel at (50, 25) expected 255 but got 0
  │ 
  │ _assertPixel@http://web-platform.test:8000/common/canvas-tests.js:39:5
  │ @http://web-platform.test:8000/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-4.html:26:1
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  │ _addTest/</<@http://web-platform.test:8000/common/canvas-tests.js:62:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  └ _addTest/<@http://web-platform.test:8000/common/canvas-tests.js:59:9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-5.html:
  │ FAIL [expected PASS] Canvas test: 2d.fillStyle.parse.rgb-clamp-5
  │   → assert_equals: Green channel of the pixel at (50, 25) expected 255 but got 0
  │ 
  │ _assertPixel@http://web-platform.test:8000/common/canvas-tests.js:39:5
  │ @http://web-platform.test:8000/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-5.html:26:1
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  │ _addTest/</<@http://web-platform.test:8000/common/canvas-tests.js:62:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  └ _addTest/<@http://web-platform.test:8000/common/canvas-tests.js:59:9
@SimonSapin SimonSapin mentioned this pull request Apr 24, 2017
Merged
@SimonSapin SimonSapin force-pushed the cssparserup branch from 25de180 to 3a9a435 Apr 24, 2017
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 24, 2017

Fixed a cssparser bug and updated expectations.

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

📌 Commit 3a9a435 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

⌛ Testing commit 3a9a435 with merge 589f0d9...
bors-servo added a commit that referenced this pull request Apr 24, 2017
@bors-servo
Auto merge of #16589 - servo:cssparserup, r=emilio
Loading status checks…
589f0d9 
Update to cssparser 0.13

servo/rust-cssparser#140

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16589)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

💔 Test failed - mac-rel-wpt1
@SimonSapin SimonSapin force-pushed the cssparserup branch from 3a9a435 to 7c85458 Apr 24, 2017
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 24, 2017

Missed some test expectation changes, fixed.

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

📌 Commit 7c85458 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

⌛ Testing commit 7c85458 with merge 2155b2a...
bors-servo added a commit that referenced this pull request Apr 24, 2017
@bors-servo
Auto merge of #16589 - servo:cssparserup, r=emilio
Loading status checks…
2155b2a 
Update to cssparser 0.13

servo/rust-cssparser#140

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16589)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

💔 Test failed - mac-rel-css
@SimonSapin
Update to cssparser 0.13
Loading status checks…
11cef13
@SimonSapin SimonSapin force-pushed the cssparserup branch from 7c85458 to 11cef13 Apr 24, 2017
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 24, 2017

Marked as failing two tests from css-color-3_dev that contain

		<div>Note: the rules tested by this test may be changed in
		future levels of the CSS Color Module.</div>

They test that syntax now valid in level 4 is invalid.

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

📌 Commit 11cef13 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

⌛ Testing commit 11cef13 with merge e3e10ad...
bors-servo added a commit that referenced this pull request Apr 24, 2017
@bors-servo
Auto merge of #16589 - servo:cssparserup, r=emilio
Loading status checks…
e3e10ad 
Update to cssparser 0.13

servo/rust-cssparser#140

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16589)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing e3e10ad to master...
@bors-servo bors-servo merged commit 11cef13 into master Apr 25, 2017
1 of 4 checks passed
1 of 4 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
dependency-ci Checking Dependencies
Details
homu Test successful
Details
This was referenced Apr 25, 2017
Closed
Merged
@SimonSapin SimonSapin deleted the cssparserup branch Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @emilio @bors-servo @jdm @KiChjang
You can’t perform that action at this time.