Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to cssparser 0.13 #16589

Merged
merged 1 commit into from Apr 25, 2017
Merged

Update to cssparser 0.13 #16589

merged 1 commit into from Apr 25, 2017

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Apr 24, 2017 •
edited by larsbergstrom

servo/rust-cssparser#140

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/properties/properties.mako.rs
  • @KiChjang: components/script/Cargo.toml, components/script_layout_interface/Cargo.toml
  • @fitzgen: components/script/Cargo.toml, components/script_layout_interface/Cargo.toml
  • @emilio: components/style/Cargo.toml, components/layout/Cargo.toml, ports/geckolib/Cargo.toml, components/style/properties/properties.mako.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 24, 2017
@emilio
Copy link
Member

emilio commented Apr 24, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 25de180 has been approved by emilio

@highfive highfive assigned emilio and unassigned KiChjang Apr 24, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 24, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 25de180 with merge 9d6480c...

bors-servo pushed a commit that referenced this pull request Apr 24, 2017
Auto merge of #16589 - servo:cssparserup, r=emilio
9d6480c 
Update to cssparser 0.13

servo/rust-cssparser#140

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16589)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 24, 2017
@jdm
Copy link
Member

jdm commented Apr 24, 2017 

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-2

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-7

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-8

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsl-9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-2

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-7

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-8

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-hsla-9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-2

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgb-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-1

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-3.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-3

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-4.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-4

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-5.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-5

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-6.html:
  └ PASS [expected FAIL] Canvas test: 2d.fillStyle.parse.css-color-4-rgba-6

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-3.html:
  │ FAIL [expected PASS] Canvas test: 2d.fillStyle.parse.rgb-clamp-3
  │   → assert_equals: Green channel of the pixel at (50, 25) expected 255 but got 0
  │ 
  │ _assertPixel@http://web-platform.test:8000/common/canvas-tests.js:39:5
  │ @http://web-platform.test:8000/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-3.html:26:1
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  │ _addTest/</<@http://web-platform.test:8000/common/canvas-tests.js:62:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  └ _addTest/<@http://web-platform.test:8000/common/canvas-tests.js:59:9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-4.html:
  │ FAIL [expected PASS] Canvas test: 2d.fillStyle.parse.rgb-clamp-4
  │   → assert_equals: Green channel of the pixel at (50, 25) expected 255 but got 0
  │ 
  │ _assertPixel@http://web-platform.test:8000/common/canvas-tests.js:39:5
  │ @http://web-platform.test:8000/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-4.html:26:1
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  │ _addTest/</<@http://web-platform.test:8000/common/canvas-tests.js:62:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  └ _addTest/<@http://web-platform.test:8000/common/canvas-tests.js:59:9

  ▶ Unexpected subtest result in /2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-5.html:
  │ FAIL [expected PASS] Canvas test: 2d.fillStyle.parse.rgb-clamp-5
  │   → assert_equals: Green channel of the pixel at (50, 25) expected 255 but got 0
  │ 
  │ _assertPixel@http://web-platform.test:8000/common/canvas-tests.js:39:5
  │ @http://web-platform.test:8000/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.rgb-clamp-5.html:26:1
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  │ _addTest/</<@http://web-platform.test:8000/common/canvas-tests.js:62:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  └ _addTest/<@http://web-platform.test:8000/common/canvas-tests.js:59:9

@SimonSapin SimonSapin mentioned this pull request Apr 24, 2017
Merged
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 24, 2017
@SimonSapin
Copy link
Member Author

Fixed a cssparser bug and updated expectations.

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 3a9a435 has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 24, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 3a9a435 with merge 589f0d9...

bors-servo pushed a commit that referenced this pull request Apr 24, 2017
Auto merge of #16589 - servo:cssparserup, r=emilio
589f0d9 
Update to cssparser 0.13

servo/rust-cssparser#140

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16589)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 24, 2017
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Apr 24, 2017
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 24, 2017
@SimonSapin
Copy link
Member Author

Missed some test expectation changes, fixed.

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 7c85458 has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 24, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 7c85458 with merge 2155b2a...

bors-servo pushed a commit that referenced this pull request Apr 24, 2017
Auto merge of #16589 - servo:cssparserup, r=emilio
2155b2a 
Update to cssparser 0.13

servo/rust-cssparser#140

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16589)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 24, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 24, 2017
@SimonSapin
Copy link
Member Author

Marked as failing two tests from css-color-3_dev that contain

		<div>Note: the rules tested by this test may be changed in
		future levels of the CSS Color Module.</div>

They test that syntax now valid in level 4 is invalid.

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 11cef13 has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 24, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 11cef13 with merge e3e10ad...

bors-servo pushed a commit that referenced this pull request Apr 24, 2017
Auto merge of #16589 - servo:cssparserup, r=emilio
e3e10ad 
Update to cssparser 0.13

servo/rust-cssparser#140

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16589)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing e3e10ad to master...

@bors-servo bors-servo merged commit 11cef13 into master Apr 25, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 25, 2017
This was referenced Apr 25, 2017
Closed
Merged
@SimonSapin SimonSapin deleted the cssparserup branch April 25, 2017 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SimonSapin @highfive @emilio @bors-servo @jdm @KiChjang