Prefixed intrinsic size value #16962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
|
All patches have been reviewed by @Manishearth |
|
@bors-servo: delegate+ |
|
✌️ @hiikezoe can now approve this pull request |
|
☔ The latest upstream changes (presumably #16960) made this pull request unmergeable. Please resolve the merge conflicts. |
hiikezoe
force-pushed
the
prefixed-intrinsic-size-value
branch
from
2fe2916
to
26e19f2
Compare
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
May 20, 2017
Prefixed intrinsic size value <!-- Please describe your changes on the following line: --> This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1355402 - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #16788 - [X] These changes do not require tests because it's for stylo <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16962) <!-- Reviewable:end -->
added 5 commits
May 21, 2017 08:33
… {Min,Max}Length.
So that we can reuse this for non-min-prefixed properties (e.g. width).
auto() and zero() are used in the parser for flex shorthand property.
hiikezoe
force-pushed
the
prefixed-intrinsic-size-value
branch
from
26e19f2
to
d06af89
Compare
|
@bors-servo r=Manishearth |
|
📌 Commit d06af89 has been approved by |
highfive
added
S-awaiting-merge
|
⌛ Testing commit d06af89 with merge f56f4675eedecce37c798f324dad187cd66d70e0... |
|
💔 Test failed - linux-rel-css |
highfive
added
S-tests-failed
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
May 22, 2017
…shearth Prefixed intrinsic size value <!-- Please describe your changes on the following line: --> This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1355402 - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #16788 - [X] These changes do not require tests because it's for stylo <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16962) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1355402
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is