Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace iterator struct with anonymous return iterator type. #17488

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

frewsxcv
Copy link
Contributor

@frewsxcv frewsxcv commented Jun 23, 2017

hi servo. it's been
some time. here's a pull request.
i hope you like it.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/nodelist.rs
  • @KiChjang: components/script/dom/nodelist.rs

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 23, 2017
@jdm
Copy link
Member

jdm commented Jun 23, 2017

@bors-servo: r+
This witchcraft, but I like it.

@bors-servo
Copy link
Contributor

📌 Commit 917fe92 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 23, 2017
@frewsxcv
Copy link
Contributor Author

@bors p=-7

@frewsxcv
Copy link
Contributor Author

@bors-servo p=-7

not really an important pr

@frewsxcv
Copy link
Contributor Author

oh, there's a new 'tree closed' thing now in the queue. guess i'll bring this back to 0

@bors-servo p=0

@bors-servo
Copy link
Contributor

⌛ Testing commit 917fe92 with merge bc5e8f8...

bors-servo pushed a commit that referenced this pull request Jun 23, 2017
Replace iterator struct with anonymous return iterator type.

```
hi servo. it's been
some time. here's a pull request.
i hope you like it.
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17488)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing bc5e8f8 to master...

@bors-servo bors-servo merged commit 917fe92 into servo:master Jun 23, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 23, 2017
frewsxcv added a commit to frewsxcv/servo that referenced this pull request Jun 23, 2017
bors-servo pushed a commit that referenced this pull request Jun 24, 2017
Replace iterator struct with anonymous return iterator types.

Similar to #17488.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17503)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 26, 2017
…terator types (from frewsxcv:frewsxcv-return-node-list-2); r=mbrubeck

Similar to servo/servo#17488.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1d045e5c3b0f1b07fcf1f3513957c2378db0313c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 600fe56d340000dae116ab96e6fe894e5eab1810
Manishearth pushed a commit to Manishearth/gecko-dev that referenced this pull request Jun 27, 2017
…terator types (from frewsxcv:frewsxcv-return-node-list-2); r=mbrubeck

Similar to servo/servo#17488.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1d045e5c3b0f1b07fcf1f3513957c2378db0313c
aethanyc pushed a commit to aethanyc/gecko-dev that referenced this pull request Jun 28, 2017
…terator types (from frewsxcv:frewsxcv-return-node-list-2); r=mbrubeck

Similar to servo/servo#17488.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1d045e5c3b0f1b07fcf1f3513957c2378db0313c
JerryShih pushed a commit to JerryShih/gecko-dev that referenced this pull request Jul 4, 2017
…terator types (from frewsxcv:frewsxcv-return-node-list-2); r=mbrubeck

Similar to servo/servo#17488.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1d045e5c3b0f1b07fcf1f3513957c2378db0313c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…terator types (from frewsxcv:frewsxcv-return-node-list-2); r=mbrubeck

Similar to servo/servo#17488.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1d045e5c3b0f1b07fcf1f3513957c2378db0313c

UltraBlame original commit: ace99fd0752db63b091f1fc47a5f2a9dbf01a2a5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
…terator types (from frewsxcv:frewsxcv-return-node-list-2); r=mbrubeck

Similar to servo/servo#17488.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1d045e5c3b0f1b07fcf1f3513957c2378db0313c

UltraBlame original commit: ace99fd0752db63b091f1fc47a5f2a9dbf01a2a5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…terator types (from frewsxcv:frewsxcv-return-node-list-2); r=mbrubeck

Similar to servo/servo#17488.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1d045e5c3b0f1b07fcf1f3513957c2378db0313c

UltraBlame original commit: ace99fd0752db63b091f1fc47a5f2a9dbf01a2a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants