make sure proper frame tree is sent when iframes change #18149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
paulrouget
force-pushed
the
hittest-issue
branch
from
c0a2696
to
f87c4eb
Compare
cbrewster
approved these changes
Aug 19, 2017
| break; | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| // Only send the frame tree if it's the active one or if no frame tree | ||
| // has been sent yet. | ||
| if self.active_browser_id == None || Some(top_level_browsing_context_id) == self.active_browser_id { |
There was a problem hiding this comment.
nit: self.active_browser_id.is_none()
|
|
||
| } | ||
|
|
||
| // Send the current frame tree to compositor |
| @@ -2908,12 +2898,12 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF> | |||
| }) | |||
| } | |||
|
|
|||
| // Send the current frame tree to compositor | |||
| fn send_frame_tree(&mut self, top_level_browsing_context_id: TopLevelBrowsingContextId) { | |||
| // Re-send the frame tree to the compositor. | |||
|
@bors-servo delegate+ |
|
✌️ @paulrouget can now approve this pull request |
paulrouget
force-pushed
the
hittest-issue
branch
from
f87c4eb
to
4edac8e
Compare
|
@bors-servo r=cbrewster |
|
📌 Commit 4edac8e has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 21, 2017
make sure proper frame tree is sent when iframes change We ran into a hittest issue because the frame tree was not correctly updated after #17425. The frame tree should be updated on tab change (via send_frame_tree) or when the frame sub tree changes and it's the active one (via update_frame_tree_if_active). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #18101 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18149) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a hittest issue because the frame tree was not correctly updated after #17425.
The frame tree should be updated on tab change (via send_frame_tree) or when the frame sub tree changes and it's the active one (via update_frame_tree_if_active).
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is