Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link hitboxes do not move when scrolling page #18101

Closed
atouchet opened this issue Aug 16, 2017 · 8 comments · Fixed by #18149
Closed

Link hitboxes do not move when scrolling page #18101

atouchet opened this issue Aug 16, 2017 · 8 comments · Fixed by #18149
Labels
A-layout/query C-reproduced I-bustage The effect of the issue remaining unresolved.

Comments

@atouchet
Copy link
Contributor

atouchet commented Aug 16, 2017 •
edited
Loading

Steps to reproduce:

  1. Load web page that scrolls vertically and has clickable links near the bottom of the page.
  2. Scroll down the page.
  3. Try to click a link.
  4. The link doesn't work properly.

I believe this is a recent regression as I do not recall running into this issue previously. Tested in Windows 10.
@jdm
Copy link
Member

jdm commented Aug 17, 2017

I can reproduce this with ./mach run -b and visiting http://news.ycombinator.org. I cannot reproduce it with ./mach run http://news.ycombinator.org, so it's specifically related to hit testing inside of an iframe.

@jdm jdm added A-layout/query C-reproduced I-bustage The effect of the issue remaining unresolved. labels Aug 17, 2017
@jdm
Copy link
Member

jdm commented Aug 17, 2017 •
edited
Loading

This is a regression from #17425 according to my bisection. cc @paulrouget

@paulrouget
Copy link
Contributor

If it's because of #17425, I would bet on a Browser API breakage.

I'll look at it.

@paulrouget
Copy link
Contributor

Really looks like a hittest issue though…

@atouchet
Copy link
Contributor Author

@paulrouget do you have any idea if your PR could have also caused #18098? That issue appeared right around the same time.

@paulrouget
Copy link
Contributor

paulrouget commented Aug 17, 2017 •
edited
Loading

@atouchet I don't know. I'll investigate tomorrow.

@paulrouget
Copy link
Contributor

The hittest issue only happens with mozbrowser ifames.

@paulrouget
Copy link
Contributor

paulrouget commented Aug 18, 2017 •
edited
Loading

In these tests:

servo/components/constellation/constellation.rs

Line 2311 in 92176d1

if let Some(id) = self.active_browser_id {

servo/components/constellation/constellation.rs

Line 2473 in 92176d1

// Build frame tree

we need to resolve the actual top level browsing context.

This was referenced Aug 19, 2017
Merged
Closed
bors-servo pushed a commit that referenced this issue Aug 21, 2017
Auto merge of #18149 - paulrouget:hittest-issue, r=cbrewster
a1006a5 
make sure proper frame tree is sent when iframes change

We ran into a hittest issue because the frame tree was not correctly updated after #17425.

The frame tree should be updated on tab change (via send_frame_tree) or when the frame sub tree changes and it's the active one (via update_frame_tree_if_active).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #18101 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18149)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/query C-reproduced I-bustage The effect of the issue remaining unresolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make sure proper frame tree is sent when iframes change paulrouget/servo
3 participants
@jdm @paulrouget @atouchet