style: Sync changes from mozilla-central. #21036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
|
@bors-servo r+ |
|
📌 Commit d64c851 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jun 11, 2018
style: Sync changes from mozilla-central. See each individual commit for details.
|
💔 Test failed - linux-rel-wpt |
highfive
added
S-tests-failed
|
@bors-servo r+
|
|
📌 Commit 92c9cdf has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jun 12, 2018
style: Sync changes from mozilla-central. See each individual commit for details. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21036) <!-- Reviewable:end -->
|
💔 Test failed - mac-dev-unit |
highfive
added
S-tests-failed
|
Oh dear, this updates cssparser, which reintroduces the intermittent stack overflow in build.rs :( |
highfive
added
S-awaiting-review
It's only used for the error path in property parsing, so most of the time is not useful. Use the just-introduced NonCustomPropertyId::name to preserve the alias name, which we were doing by passing the name around. Bug: 1466645 Reviewed-by: xidorn MozReview-Commit-ID: 46xxZKCoeBB
…-variations.enabled. Atomic<bool> is implemented in terms of AtomicBase<uint32_t>, because that way you don't need to depend on atomic 1-byte operations. That means that the rust bindgen sees it as a u32, not a bool. It's a bit concerning that the rust code seems to be doing an unsynchronized read here, but given this is a RelaxedAtomic, that's probably ok. Bug: 1467134 Reviewed-by: emilio
Refactored StyleComplexColor to support "complex" blending between
background (numeric) color and foreground color (currentColor).
Made explicit the distinction between numeric, currentColor and a
complex blend in Gecko and Stylo.
This is to support SMIL animation, for example, of the form:
<animate from="rgb(10,20,30)" by="currentColor" ... />
Bug: 1465307
Reviewed-by: hiro,xidorn
MozReview-Commit-ID: IUAK8P07gtm
Bug: 1466963 Reviewed-by: xidorn MozReview-Commit-ID: A219QehiMqZ
Nobody looks at the result from parsing, but this is the right thing to return. Bug: 1466963 Reviewed-by: xidorn MozReview-Commit-ID: 9P5VARiPIAk
Bug: 1466963 Reviewed-by: xidorn MozReview-Commit-ID: 1YrlOvktag9
Bug: 1466963 Reviewed-by: xidorn MozReview-Commit-ID: 4vyN9iLT7e3
Bug: 1466963 Reviewed-by: xidorn MozReview-Commit-ID: L9LzpPt4js4
GCC doesn't like StyleComplexColor with constructor in an anonymous struct in an anonymous union. Replace the use of a union to access `mBorder[..]Color` fields as an array with an accessor methods. Bug: 1465307 Reviewed-by: xidorn MozReview-Commit-ID: 1Wulh1qKYCZ
Extract the common parts of `animated::Color` and `computed::Color` out into `generics::color::Color<T>` that is generic over the type of RGBA color. Bug: 1465307 Reviewed-by: xidorn MozReview-Commit-ID: EymSr7aqnAP
This is intended to be used by GetComputedStyle when there's no layout dependency. Bug: 1467536 Reviewed-by: xidorn MozReview-Commit-ID: 3GAbjo1uQ34
…properties. The idea is to turn the simple properties into a blacklist instead really soon, and fix the offending ones soon after, so that only shorthands and properties with layout dependence (and maybe the scrollbar properties, because the poke at LookAndFeel) are not serialized by Servo. Bug: 1467536 Reviewed-by: xidorn MozReview-Commit-ID: JTLNnmXzny8
Bug: 1416282 Reviewed-by: xidorn MozReview-Commit-ID: GTnFyZnXR84
|
@bors-servo r+ |
|
📌 Commit 2106cc4 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jun 12, 2018
style: Sync changes from mozilla-central. See each individual commit for details. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21036) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each individual commit for details.
This change is