New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Sync changes from mozilla-central. #21036
Commits on Jun 12, 2018
-
style: Make contain:paint trigger clipping independent of the overflo…
…w property. Bug: 1465250 Reviewed-by: mattwoodrow MozReview-Commit-ID: 2QbfZD1jnWX
Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Remove invalid assertion.
We can look at stale styles while trying to figure out if we need any invalidation, and that's ok. Bug: 1449243 MozReview-Commit-ID: 4mBIFNm9qJv
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Make the transition-property code make more sense.
We were working around the lack of alias support during parsing in TransitionProperty by doing a Gecko lookup. That's a hack and is now gone. Bug: 1419695 Reviewed-by: xidorn MozReview-Commit-ID: EptUvJNTrZr
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Hide multiple -moz-window-* properties from content.
Bug: 1419695 Reviewed-by: xidorn MozReview-Commit-ID: Jsqt3kqjPiq
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Move TransitionProperty where it belongs.
Bug: 1419695 Reviewed-by: xidorn MozReview-Commit-ID: 9PN6VfbDbLA
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Use custom_properties::Name in TransitionProperty.
Bug: 1419695 Reviewed-by: xidorn MozReview-Commit-ID: BUSWrcA5hkw
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Introduce css(parse_condition).
This will allow us to add a pref for this, and to parse it only on chrome easily. Bug: 1288572 Reviewed-by: xidorn MozReview-Commit-ID: L1rsyc2A2hu
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Hide -moz- display values from content behind a pref.
Bug: 1288572 Reviewed-by: xidorn MozReview-Commit-ID: HDQPub043H1
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Don't hide -moz-box / -moz-inline-box yet.
I'd really prefer to not land this patch, but... Bug: 1288572 Reviewed-by: mats MozReview-Commit-ID: HzmvhTd32gz
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Update smallbitvec to v2.1.1.
Actual code changes reviewed upstream in: servo/smallbitvec#12 Bug: 1466647 MozReview-Commit-ID: 3vKVPMovBj
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Sprinkle some inline in methods that are just pointer-chasing …
…or function calls. MozReview-Commit-ID: 8G2NQPBVuXn
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Sprinkle some #[inline] on methods that have inline fast-paths.
MozReview-Commit-ID: 5kOmctLTAX0
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Don't look at the rule type from value parsing.
This would cause properties to change the value semantics between, e.g., @Keyframes and non-@Keyframes, which would be observable. It happens not to be observable since the animation-* and transition-* properties are not allowed in @Keyframes, nor have bits in `contain`, and none of the two properties are allowed in @page. But I think it's the right thing to do. This still causes a quirk like a property value in chrome / user origins being potentially different if the value is specified via CSS var functions. But I think that is fine. Bug: 1466136 Reviewed-by: hiro MozReview-Commit-ID: GhoPt0I34oO
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Work around a bindgen bug on Android.
Bug: 1466406 Reviewed-by: xidorn MozReview-Commit-ID: 2lltjH7IoZu
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Make pseudo-elements work with :host.
Imported WebKit's test as a WPT. Bug: 1465291 Reviewed-by: xidorn MozReview-Commit-ID: 19ZThuoqKLW
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Move some parsing-only attributes to use #[parse(..)] instead …
…of #[css(..)]. I need to admit I'm ambivalent about this one :). Bug: 1466609 Reviewed-by: xidorn MozReview-Commit-ID: F1jlfnQKXwo
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Make the threadsafe refcounting macros more reusable.
Bug: 1466609 Reviewed-by: xidorn MozReview-Commit-ID: IanxqRksGqE
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Make clearing atoms slightly more ergonomic.
I prefer to do it this way because Atom has inline paths for static atoms and such. Bug: 1466609 Reviewed-by: xidorn MozReview-Commit-ID: CFsBHl80KDY
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Avoid useless allocations in custom property name serialization.
And make transition-property more correct by serializing --0 unescaped instead of escaped. Bug: 1466645 Reviewed-by: xidorn MozReview-Commit-ID: CCBSe5Frd0d
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Make getting a property name explicitly an indexing operation.
The six milliseconds spent in Olli's profile make me thing this is not getting optimized and we expected. Also move it to NonCustomPropertyId, so it works for aliases properly too. Bug: 1466645 Reviewed-by: xidorn MozReview-Commit-ID: 4d76Z55ZBEH
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Remove PropertyId::name.
It's only used for the error path in property parsing, so most of the time is not useful. Use the just-introduced NonCustomPropertyId::name to preserve the alias name, which we were doing by passing the name around. Bug: 1466645 Reviewed-by: xidorn MozReview-Commit-ID: 46xxZKCoeBB
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Use Atomic<bool> for the staticpref version of layout.css.font…
…-variations.enabled. Atomic<bool> is implemented in terms of AtomicBase<uint32_t>, because that way you don't need to depend on atomic 1-byte operations. That means that the rust bindgen sees it as a u32, not a bool. It's a bit concerning that the rust code seems to be doing an unsynchronized read here, but given this is a RelaxedAtomic, that's probably ok. Bug: 1467134 Reviewed-by: emilio
Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Extend StyleComplexColor to support additive blending.
Refactored StyleComplexColor to support "complex" blending between background (numeric) color and foreground color (currentColor). Made explicit the distinction between numeric, currentColor and a complex blend in Gecko and Stylo. This is to support SMIL animation, for example, of the form: <animate from="rgb(10,20,30)" by="currentColor" ... /> Bug: 1465307 Reviewed-by: hiro,xidorn MozReview-Commit-ID: IUAK8P07gtmUnverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Inline some trivial bits.
Bug: 1466963 Reviewed-by: xidorn MozReview-Commit-ID: A219QehiMqZ
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
Nobody looks at the result from parsing, but this is the right thing to return. Bug: 1466963 Reviewed-by: xidorn MozReview-Commit-ID: 9P5VARiPIAk
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Remove unused PropertyDeclarationBlock::set_importance.
Bug: 1466963 Reviewed-by: xidorn MozReview-Commit-ID: 1YrlOvktag9
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Add a before-change callback to remove_property.
Bug: 1466963 Reviewed-by: xidorn MozReview-Commit-ID: 4vyN9iLT7e3
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Trivially simplify a condition.
Bug: 1466963 Reviewed-by: xidorn MozReview-Commit-ID: L9LzpPt4js4
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Fix nsStyleBorder::mBorderColor for GCC.
GCC doesn't like StyleComplexColor with constructor in an anonymous struct in an anonymous union. Replace the use of a union to access `mBorder[..]Color` fields as an array with an accessor methods. Bug: 1465307 Reviewed-by: xidorn MozReview-Commit-ID: 1Wulh1qKYCZ
Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Extract {animated,computed}::Color common parts.
Extract the common parts of `animated::Color` and `computed::Color` out into `generics::color::Color<T>` that is generic over the type of RGBA color. Bug: 1465307 Reviewed-by: xidorn MozReview-Commit-ID: EymSr7aqnAP
Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Add a Servo API to get the serialized style of a property.
This is intended to be used by GetComputedStyle when there's no layout dependency. Bug: 1467536 Reviewed-by: xidorn MozReview-Commit-ID: 3GAbjo1uQ34
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Add CssPropFlags::SerializedByServo and use it on some simple …
…properties. The idea is to turn the simple properties into a blacklist instead really soon, and fix the offending ones soon after, so that only shorthands and properties with layout dependence (and maybe the scrollbar properties, because the poke at LookAndFeel) are not serialized by Servo. Bug: 1467536 Reviewed-by: xidorn MozReview-Commit-ID: JTLNnmXzny8
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
Bug: 1416282 Reviewed-by: xidorn MozReview-Commit-ID: GTnFyZnXR84
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
emilio committed
Jun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
emilio committed
Jun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
emilio committed
Jun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
style: Derive Animate for ComplexColorRatios.
emilio committedJun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
emilio committed
Jun 12, 2018 Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits -
Unverified
This user has not uploaded their public key yet.GPG key ID: 056B727BB9C1027C Learn about signing commits